Display app versions #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argon
requested changes
Sep 17, 2016
| for update in updates { | ||
| print("\(update.itemIdentifier) \(update.title) (\(update.bundleVersion))") | ||
| if let installed = softwareMap.productForBundleIdentifier(update.bundleID) { |
There was a problem hiding this comment.
Very nice. This has made me realise a better way to do the multi-upgrade "is installed" checks
| if let installed = softwareMap.productForBundleIdentifier(update.bundleID) { | ||
| print("\(update.itemIdentifier) \(update.title) (\(installed.bundleVersion) -> \(update.bundleVersion))") | ||
| } else { | ||
| print("\(update.itemIdentifier) \(update.title) (\(update.bundleVersion))") |
There was a problem hiding this comment.
I would like to see some kind of indicator that this update is pending even though the app store can't find the currently installed version (seems like it shouldn't happen)
Perhaps:
print("\(update.itemIdentifier) \(update.title) (unknown -> \(update.bundleVersion))")There was a problem hiding this comment.
Yep, this situation is unlikely to happen, but let's make it "unknown" just in case
argon
approved these changes
Sep 17, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #43