fix(ext4): replaced filepath.Separator with "/" #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an inconsistency when the library is used on Windows. On Linux, the file path separator is "/", but on Windows it is "\". As "/" is already hardcoded elsewhere, and "/" is a forbidden character in file names and folders on Windows already, all instances have been replaced with "/". Closes masahiro331#2
SoftPoison
force-pushed
the
2_windows_incompatibility
branch
from
1c0edcb
to
fb1adb5
Compare
|
Oh!!!! I'll review it. |
|
@SoftPoison |
|
Thanks for merging! :) |
|
If you don't mind, here too. 👨 |
|
Sure thing! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an inconsistency when the library is used on Windows.
On Linux, the file path separator is "/", but on Windows it is "". As "/" is already hardcoded elsewhere, and "/" is a forbidden character in file names and folders on Windows already, all instances have been replaced with "/".
Closes #2