Fails to open contained files when running on Windows #2
Comments
SoftPoison
added a commit
to SoftPoison/go-ext4-filesystem
that referenced
this issue
Feb 4, 2023
This fixes an inconsistency when the library is used on Windows. On Linux, the file path separator is "/", but on Windows it is "\". As "/" is already hardcoded elsewhere, and "/" is a forbidden character in file names and folders on Windows already, all instances have been replaced with "/". Closes masahiro331#2
This was referenced Feb 4, 2023
masahiro331
pushed a commit
that referenced
this issue
Feb 23, 2023
This fixes an inconsistency when the library is used on Windows. On Linux, the file path separator is "/", but on Windows it is "\". As "/" is already hardcoded elsewhere, and "/" is a forbidden character in file names and folders on Windows already, all instances have been replaced with "/". Closes #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The use of
filepath.Separatorinext4/fs.goleads to the error "panic: open /<filename redacted>: invalid argument" when running on Windows (since its separator is\instead of/)I suggest changing instances of
filepath.Separatorto"/"(or vice versa; although/is a forbidden character anyway so it should be safe to just hardcode to/)The text was updated successfully, but these errors were encountered: