Skip to content
This repository has been archived by the owner on Aug 1, 2022. It is now read-only.

feat(DDD): Add IGeneratesDomainEvents #52

Merged
merged 2 commits into from
May 11, 2022
Merged

feat(DDD): Add IGeneratesDomainEvents #52

merged 2 commits into from
May 11, 2022

Conversation

zhenlei520
Copy link
Contributor

No description provided.

@zhenlei520 zhenlei520 requested a review from doddgu May 10, 2022 09:13
@@ -3,7 +3,7 @@

namespace Masa.BuildingBlocks.Ddd.Domain.Entities;

public abstract class AggregateRoot : Entity, IAggregateRoot
public abstract class AggregateRoot : Entity, IGeneratesDomainEvents
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the IAggregateRoot?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misoperation, accidentally removed


namespace Masa.BuildingBlocks.Ddd.Domain.Entities;

public interface IGeneratesDomainEvents
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IGeneratesDomainEvents -> IGenerateDomainEvents

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

processed

@zhenlei520 zhenlei520 requested a review from doddgu May 11, 2022 01:31
Copy link
Contributor

@doddgu doddgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doddgu doddgu merged commit 44285eb into main May 11, 2022
@zhenlei520 zhenlei520 deleted the feature/domain_event branch May 11, 2022 01:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants