Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added JWT Oauth Support and Response documentation support #156

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

kushal-likhi
Copy link

Following Updates are done

  • Now JWT OAuth 2.0 is supported.
  • Now we can document response types for the API. See the jwttest.json for details.

Attached the response documentation screenshot

jwt based oauth 2 0 auth code api documentation

@@ -3,3 +3,4 @@ node_modules/*
config.json
logs/*
pids/*
.idea/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an IDE specific addition. It should go in your personal/global .gitignore

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aah, yes,, true... sorry for that. Will take care of this in future.

@mtougeron mtougeron added the auth label Mar 25, 2014
app.set('views', __dirname + '/views');
app.set('view engine', 'jade');
app.use(function (req, res, next) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what exactly does this do?

@phairow
Copy link
Contributor

phairow commented Oct 9, 2014

@kushal-likhi this is a nice feature to add. I'd like to clean up this PR so we can merge it. I just have a few concerns.

  1. I don't know why the domain module is needed
  2. white space is changed everywhere so it's hard to see what the actual changes are, this should be cleaned up
  3. private api's should not be committed to the core application, we need to support loading external api definitions in a better way.
  4. since I have no familiarity with JWT it will take a little research to verify the feature

aside from the nitpicking this looks like a great addition to iodocs :)

@robksawyer
Copy link

I'd like to add JWT authentication to my docs. Anyone have any luck with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants