Skip to content

Added JWT Oauth Support and Response documentation support #156

Open
wants to merge 7 commits into from

4 participants

@kushal-likhi

###Following Updates are done###

  • Now JWT OAuth 2.0 is supported.
  • Now we can document response types for the API. See the jwttest.json for details.

###Attached the response documentation screenshot###
jwt based oauth 2 0 auth code api documentation

@mtougeron mtougeron commented on the diff Mar 25, 2014
.gitignore
@@ -3,3 +3,4 @@ node_modules/*
config.json
logs/*
pids/*
+.idea/
@mtougeron
mtougeron added a note Mar 25, 2014

This is an IDE specific addition. It should go in your personal/global .gitignore

@kushal-likhi
kushal-likhi added a note Mar 26, 2014

Aah, yes,, true... sorry for that. Will take care of this in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@mtougeron mtougeron added the auth label Mar 25, 2014
@phairow phairow commented on the diff Oct 9, 2014
app.set('views', __dirname + '/views');
app.set('view engine', 'jade');
+ app.use(function (req, res, next) {
@phairow
phairow added a note Oct 9, 2014

what exactly does this do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@phairow phairow commented on the diff Oct 9, 2014
public/data/apiconfig.json
@@ -50,6 +50,22 @@
},
"keyParam":""
},
+ "jwttest": {
@phairow
phairow added a note Oct 9, 2014

don't add private api's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@phairow phairow commented on the diff Oct 9, 2014
public/data/jwttest.json
@@ -0,0 +1,59 @@
+{
@phairow
phairow added a note Oct 9, 2014

this file should not be added to the repo since it's for a private api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@phairow
phairow commented Oct 9, 2014

@kushal-likhi this is a nice feature to add. I'd like to clean up this PR so we can merge it. I just have a few concerns.

1) I don't know why the domain module is needed
2) white space is changed everywhere so it's hard to see what the actual changes are, this should be cleaned up
3) private api's should not be committed to the core application, we need to support loading external api definitions in a better way.
4) since I have no familiarity with JWT it will take a little research to verify the feature

aside from the nitpicking this looks like a great addition to iodocs :)

@robksawyer

I'd like to add JWT authentication to my docs. Anyone have any luck with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.