Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented parameterized base url. #220

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pkandathil
Copy link

Our team codes on servers and we have separated the workspaces by subdomain. http://{username}.domain.com. Having parameters in the baseurl greatly helps with being able to call services deployed to each user's environment.

@phairow
Copy link
Contributor

phairow commented Oct 21, 2014

Hi @pkandathil This looks like a great addition. Would you be able to include example definitions that leverage this functionality. We should also update the readme to illustrate the enhancement. I am looking at another pull request which adds tests so once that's in I can use the sample definitions to create tests for this addition. I also want to dig a little deeper on the UI change (hidden elements), it looks like you are handling the basePath, privatePath and methodPath and it's missing publicPath. Am I missing something, is publicPath covered already, or should we consider that one too?

@pkandathil
Copy link
Author

Hi @phairow
You are correct. I should add public path too. I missed that. I will make the change. I can add another example. I think it should be under the "API-LEVEL CONFIG DETAILS" section. Let me know if that is wrong. Regarding sample services. I haven't added as on my last pull request you asked me not to check in any of personal tests. Let me know if there is anything else you need.

@phairow
Copy link
Contributor

phairow commented Oct 24, 2014

That's awesome. Yeah, we shouldn't add the definitions to the main list but just send a sample in the comments here or document the functionality in the readme or something. We will get more formal on testing and documentation going forward.

@pkandathil
Copy link
Author

@phairow
I updated the docs.

@phairow
Copy link
Contributor

phairow commented Nov 4, 2014

Thanks @pkandathil will review this as soon as possible.

 On Monday, October 27, 2014 11:37 PM, pkandathil <notifications@github.com> wrote:

@phairow
I updated the docs.—
Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants