Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing devDependencies, jshint to eslint, fixed guard-for-in error #282

Closed
wants to merge 9 commits into from
Closed

Missing devDependencies, jshint to eslint, fixed guard-for-in error #282

wants to merge 9 commits into from

Conversation

travnels
Copy link
Contributor

@travnels travnels commented Nov 3, 2016 •
edited
Loading

  • istanbul is required for the test-ci script, but was missing from package.json
  • there is a mix of jshint and eslint, so moved everything over to eslint. Pined at version 2.13.x for travisci tests to pass in jobs prior to LTS (4.0)
  • fixed guard-for-in error identified by eslint

@travnels
Added missing dev dependency
bb43c9f 
istanbul is required for the test-ci script, but was missing
@coveralls
Copy link

coveralls commented Nov 3, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 97.908% when pulling bb43c9f on travnels:master into 11d89da on mashpie:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.908% when pulling bb43c9f on travnels:master into 11d89da on mashpie:master.

@coveralls
Copy link

coveralls commented Nov 3, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 97.908% when pulling e55c1ce on travnels:master into 11d89da on mashpie:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.908% when pulling e55c1ce on travnels:master into 11d89da on mashpie:master.

@travnels
Replacing jslint for eslint
e22776e 
.eslintrc and .eslintignore are already being used in the project, so
we should have this in the dev dependencies
@travnels travnels changed the title Added missing dev dependency (istanbul) Added missing dev dependencies (istanbul and eslint) Nov 3, 2016
@travnels
Guarding for-in from unexpected items in loop
aa3caf8 
Per http://eslint.org/docs/rules/guard-for-in

Looping over objects with a for in loop will include properties that
are inherited through the prototype chain. This behavior can lead to
unexpected items in your for loop.
@travnels
Replacing jshint with eslint
962d7fc
@travnels travnels changed the title Added missing dev dependencies (istanbul and eslint) Missing devDependencies, jshint to eslint, fixed guard-for-in error Nov 3, 2016
@travnels travnels mentioned this pull request Nov 3, 2016
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 97.912% when pulling 962d7fc on travnels:master into 11d89da on mashpie:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 97.912% when pulling 962d7fc on travnels:master into 11d89da on mashpie:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 97.912% when pulling 606c606 on travnels:master into 11d89da on mashpie:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 97.912% when pulling 606c606 on travnels:master into 11d89da on mashpie:master.

@coveralls
Copy link

coveralls commented Nov 3, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 97.912% when pulling 667fb40 on travnels:master into 11d89da on mashpie:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 97.912% when pulling 846950a on travnels:master into 11d89da on mashpie:master.

1 similar comment
@coveralls
Copy link

coveralls commented Nov 3, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 97.912% when pulling 846950a on travnels:master into 11d89da on mashpie:master.

@travnels
Copy link
Contributor Author

travnels commented Nov 4, 2016

Closing since I made a cleaner/squashed PR: #284

@travnels travnels closed this Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@travnels @coveralls