Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eslint and cleanup #284

Closed
wants to merge 3 commits into from
Closed

Eslint and cleanup #284

wants to merge 3 commits into from

Conversation

travnels
Copy link
Contributor

@travnels travnels commented Nov 4, 2016

  • there was a mix of jshint and eslint, so moved everything over to eslint. Pined at version 2.13.* for travisci tests to pass in jobs prior to LTS (4.0)
  • fixed guard-for-in error identified by eslint
  • istanbul is required for the test-ci script, but was missing from package.json

@travnels
Guarding for-in from unexpected items in loop
890dc4c 
Per http://eslint.org/docs/rules/guard-for-in

Looping over objects with a for in loop will include properties that
are inherited through the prototype chain. This behavior can lead to
unexpected items in your for loop.
@travnels
Replaced jshint with eslint
d8aa7b5 
added missing dependency (istanbul) for `test-ci` script
@travnels
istanbul install was moved to devDependencies
8a1ab1c
@coveralls
Copy link

coveralls commented Nov 4, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 97.912% when pulling 8a1ab1c on travnels:eslint-and-cleanup into 11d89da on mashpie:master.

@travnels travnels mentioned this pull request Nov 4, 2016
Closed
@travnels travnels closed this Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@travnels @coveralls