Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade messageformat #327

Closed
wants to merge 3 commits into from

Conversation

HollyPony
Copy link

@HollyPony HollyPony commented Sep 5, 2017

Update messageformat dependency and update tests according to doc : https://github.com/messageformat/messageformat.js

This is solving installing i18n with npm 5.4 since it's cause by this dependency.

Also, this is a break change update of messageformat so, I don't understand why should work with plurals was "other" instead of "zero" for effective "0" input.

In an other way, "zero", "two", "few" and "many" doesn't work any more so, this is probably a break changing.

After that, it's a npm error and not here.

Closes #325

@coveralls
Copy link

coveralls commented Sep 5, 2017

Coverage Status

Coverage remained the same at 97.908% when pulling 7ee277f on HollyPony:upgrade-messageformat into 11d89da on mashpie:master.

@cartuchogl
Copy link

+1
node 8.7.0 bundled npm 5.4.2

@HollyPony
Copy link
Author

I'm not sure about how to upgrade the version of i18n-node. I think it's a potential breaking change PR, so a major version respecting the semver.

@cartuchogl
Copy link

npm 5.5.1 fix the problem. Node 8 starts LTS at the end of that month. I don't know if a posible release of 8.8.0 comes bundled with a fixed version of npm.

@HollyPony
Copy link
Author

HollyPony commented Oct 17, 2017

Yup, feel free to close this PR. But I think a little package update is not so bad ^^

mashpie added a commit that referenced this pull request Oct 23, 2019
@mashpie mashpie closed this Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

installation error
4 participants