Remove V from version name #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertobaezap
previously approved these changes
Sep 15, 2023
finxo
previously approved these changes
Sep 18, 2023
adriangl
requested changes
Sep 18, 2023
|
sebastianvarela
approved these changes
Sep 19, 2023
|
A note: The version bump would be more elegant if it went in another PR to isolate the functionality of the release |
r-pedraza
approved these changes
Sep 19, 2023
It would make sense if we made more streamlined releases (aka: a proper Changelog, a proper Github release and all that stuff). I'd say it's OK for now as the version is only going to contain this single feature, but I agree about doing this if we're going to have more frequent updates and contributors 😛 |
adriangl
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR's key points
This PR removes the "v" from the version name, not to be included in the app nor in the version tags.
NOTE: For this to work properly on the first try, we should create a tag on the branch with the new format manually. We can remove a nightly tag with the "v" and create it again without it. This way, everything should be working fine.
How to review this PR?
You can run
tag_trainlocally withpush_to_repo:falseto test this.