Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bunch of extension and utilities from our main project. #34

Merged
merged 8 commits into from
Feb 1, 2024

Conversation

sebastianvarela
Copy link
Collaborator

@sebastianvarela sebastianvarela commented Jan 26, 2024

PR's key points

  • Improve String Extensions
  • Improve URL Extensions
  • Improve Combine Extensions
  • Improve Semver type

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (2a974bd) 92.85% compared to head (baa733b) 93.19%.

Files Patch % Lines
Source/UIKit/Extensions/UIImageExtensions.swift 33.33% 26 Missing ⚠️
...ce/SwiftUI/Utilities/PhaseChangeNotification.swift 0.00% 9 Missing ⚠️
Source/Foundation/Extensions/URLExtensions.swift 89.83% 6 Missing ⚠️
Tests/Helpers/FakeBundle.swift 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   92.85%   93.19%   +0.33%     
==========================================
  Files         129      146      +17     
  Lines        5630     6101     +471     
==========================================
+ Hits         5228     5686     +458     
- Misses        402      415      +13     
Flag Coverage Δ
ios 93.19% <94.17%> (+0.39%) ⬆️
mac 93.19% <94.17%> (+0.33%) ⬆️
tv 93.19% <94.17%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

r-pedraza
r-pedraza previously approved these changes Jan 29, 2024
@ThorBot
Copy link

ThorBot commented Jan 29, 2024

6 Warnings
⚠️ Big PR, try to keep changes smaller if you can 😜
⚠️ Source/Foundation/Extensions/StringExtensions+Crypto.swift#L15: 'CC_MD5' was deprecated in iOS 13.0: This function is cryptographically broken and should not be used in security contexts. Clients should migrate to SHA256 (or stronger).
⚠️ Source/Foundation/Extensions/StringExtensions+Crypto.swift#L100: 'withUnsafeBytes' is deprecated: use withUnsafeBytes\<R\>(_: (UnsafeRawBufferPointer) throws -\> R) rethrows -\> R instead
⚠️ Source/Foundation/Extensions/StringExtensions+Crypto.swift#L104: 'withUnsafeBytes' is deprecated: use withUnsafeBytes\<R\>(_: (UnsafeRawBufferPointer) throws -\> R) rethrows -\> R instead
⚠️ Source/Foundation/Extensions/StringExtensions+Crypto.swift#L15: 'CC_MD5' was deprecated in macOS 10.15: This function is cryptographically broken and should not be used in security contexts. Clients should migrate to SHA256 (or stronger).
⚠️ Source/Foundation/Extensions/StringExtensions+Crypto.swift#L15: 'CC_MD5' was deprecated in tvOS 13.0: This function is cryptographically broken and should not be used in security contexts. Clients should migrate to SHA256 (or stronger).
3 Messages
📖 ⌛️ [iOS] Slowest test: test_false took 5.004 seconds
📖 ⌛️ [mac] Slowest test: test_false took 5.010 seconds
📖 ⌛️ [tv] Slowest test: test_false took 5.006 seconds

SwiftLint found issues

Warnings

File Line Reason
CGFloatExtensionsTests.swift 10 Underscores should be used as thousand separator in large decimal numbers. (number_separator)
DecimalExtensionsTests.swift 125 Underscores should be used as thousand separator in large decimal numbers. (number_separator)
DecimalExtensionsTests.swift 134 Underscores should be used as thousand separator in large decimal numbers. (number_separator)

Generated by 🚫 Danger

@sebastianvarela sebastianvarela merged commit 571ac4b into master Feb 1, 2024
4 checks passed
@sebastianvarela sebastianvarela deleted the task/bump_utils branch February 1, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants