Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the format methods to align with the new requireme… #35

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

radostinaTachova
Copy link

PR's key points

Updated the format methods to align with the new requirements of the device details view.
With these changes, we will be able to remove the decimal extensions from the app.

How to review this PR?

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.88%. Comparing base (9176798) to head (814277c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   92.84%   92.88%   +0.03%     
==========================================
  Files         146      146              
  Lines        6125     6154      +29     
==========================================
+ Hits         5687     5716      +29     
  Misses        438      438              
Flag Coverage Δ
ios 92.87% <100.00%> (+0.03%) ⬆️
mac 92.88% <100.00%> (+0.03%) ⬆️
tv 92.88% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThorBot
Copy link

ThorBot commented Mar 5, 2024

7 Warnings
⚠️ Source/Foundation/Extensions/TimeZoneExtensions.swift#L439: Extension declares a conformance of imported type 'TimeZone' to imported protocol 'CaseIterable'; this will not behave correctly if the owners of 'Foundation' introduce this conformance in the future
⚠️ Source/Foundation/Extensions/URLExtensions.swift#L94: Extension declares a conformance of imported type 'URL' to imported protocol 'Comparable'; this will not behave correctly if the owners of 'Foundation' introduce this conformance in the future
⚠️ Source/Foundation/Extensions/StringExtensions+Crypto.swift#L15: 'CC_MD5' was deprecated in iOS 13.0: This function is cryptographically broken and should not be used in security contexts. Clients should migrate to SHA256 (or stronger).
⚠️ Source/Foundation/Extensions/StringExtensions+Crypto.swift#L100: 'withUnsafeBytes' is deprecated: use withUnsafeBytes\<R\>(_: (UnsafeRawBufferPointer) throws -\> R) rethrows -\> R instead
⚠️ Source/Foundation/Extensions/StringExtensions+Crypto.swift#L104: 'withUnsafeBytes' is deprecated: use withUnsafeBytes\<R\>(_: (UnsafeRawBufferPointer) throws -\> R) rethrows -\> R instead
⚠️ Source/Foundation/Extensions/StringExtensions+Crypto.swift#L15: 'CC_MD5' was deprecated in macOS 10.15: This function is cryptographically broken and should not be used in security contexts. Clients should migrate to SHA256 (or stronger).
⚠️ Source/Foundation/Extensions/StringExtensions+Crypto.swift#L15: 'CC_MD5' was deprecated in tvOS 13.0: This function is cryptographically broken and should not be used in security contexts. Clients should migrate to SHA256 (or stronger).
6 Messages
📖 MasMagicPills-iOSTests: Executed 259 tests, with 0 failures (0 expected) in 8.681 (8.681) seconds
📖 MasMagicPills-macOSTests: Executed 204 tests, with 0 failures (0 expected) in 5.939 (5.939) seconds
📖 MasMagicPills-tvOSTests: Executed 259 tests, with 0 failures (0 expected) in 8.323 (8.323) seconds
📖 ⌛️ [iOS] Slowest test: test_false took 5.017 seconds
📖 ⌛️ [mac] Slowest test: test_false took 5.018 seconds
📖 ⌛️ [tv] Slowest test: test_false took 5.013 seconds

SwiftLint found issues

Warnings

File Line Reason
UIViewExtensions.swift 186 Returning Void in a function declaration is redundant (redundant_void_return)
ZoomAndSnapFlowLayout.swift 80 Prefer implicit returns in closures, functions and getters (implicit_return)
CurrencyCodeType.swift 27 Include a single empty line between switch cases (vertical_whitespace_between_cases)
CurrencyCodeType.swift 29 Include a single empty line between switch cases (vertical_whitespace_between_cases)
StringExtensions+Values.swift 8 Include a single empty line between switch cases (vertical_whitespace_between_cases)
SemVerTests.swift 64 Lines should not have trailing whitespace (trailing_whitespace)
SemVerTests.swift 67 Lines should not have trailing whitespace (trailing_whitespace)
SemVerTests.swift 70 Lines should not have trailing whitespace (trailing_whitespace)
SemVerTests.swift 74 Lines should not have trailing whitespace (trailing_whitespace)
SemVerTests.swift 77 Lines should not have trailing whitespace (trailing_whitespace)
SemVerTests.swift 80 Lines should not have trailing whitespace (trailing_whitespace)
FakeBundle.swift 20 Include a single empty line between switch cases (vertical_whitespace_between_cases)

Generated by 🚫 Danger

@radostinaTachova radostinaTachova self-assigned this Mar 5, 2024
@sebastianvarela sebastianvarela changed the title (ECAPP-0000)update the format methods to align with the new requireme… Update the format methods to align with the new requireme… Oct 9, 2024
sebastianvarela and others added 3 commits October 9, 2024 13:07
* Make Semver codable

* Added Scanfile

* Fix Scanfile

* Fixed fastlane

* Removed tests

---------

Co-authored-by: JoseManuel <JoseManuel@MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants