Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL Rebar Sample App #1

Merged
merged 8 commits into from
Jan 18, 2021
Merged

GraphQL Rebar Sample App #1

merged 8 commits into from
Jan 18, 2021

Conversation

jawadali47
Copy link
Contributor

@jawadali47 jawadali47 commented Jan 13, 2021 •
edited
Loading

This PR only includes an example of how we can use a GraphQL server with projects that use rebar. No functional changes have been added to rebar since none were needed :)

@jawadali47 jawadali47 marked this pull request as ready for review January 15, 2021 20:33
@jawadali47 jawadali47 self-assigned this Jan 15, 2021
@jawadali47 jawadali47 changed the title Graphql GraphQL Rebar Sample App Jan 15, 2021
@jawadali47 jawadali47 requested review from demanbey and removed request for damien75 January 15, 2021 21:41
chazlett
chazlett approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@chazlett chazlett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It's great to have a good sample in rebar so the pattern is apparent to anyone who uses it in the future.

@jawadali47 jawadali47 merged commit 5c9ee77 into master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminpaks aminpaks aminpaks left review comments

@chazlett chazlett chazlett approved these changes

@shamsazad shamsazad Awaiting requested review from shamsazad

@demanbey demanbey Awaiting requested review from demanbey

Assignees

@jawadali47 jawadali47

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jawadali47 @chazlett @aminpaks