Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push generated files #467

Open
ASAPSegfault opened this issue Jun 26, 2023 · 5 comments · May be fixed by #468
Open

Push generated files #467

ASAPSegfault opened this issue Jun 26, 2023 · 5 comments · May be fixed by #468

Comments

@ASAPSegfault
Copy link
Contributor

No description provided.

@ASAPSegfault ASAPSegfault linked a pull request Jun 27, 2023 that will close this issue
@SlnPons
Copy link
Contributor

SlnPons commented Jun 28, 2023

@ASAPSegfault keske save dir sa?

@ASAPSegfault
Copy link
Contributor Author

ASAPSegfault commented Jun 29, 2023

Currently on the main branch someone who wishes to import packages from the wallet repository in golang cannot do it because the pkg installation is failing due to some generated files missing. @peterjah already solved this issue a few weeks ago but there have been new files added since and I needed them for the spammer.
However right now in this PR there is too much stuff added (I think), I will try removing some and then remove the draft tag from the PR

@SlnPons
Copy link
Contributor

SlnPons commented Jun 29, 2023

Ah ok! Let me know @ASAPSegfault if you need one of us to support you on this.
I will let you handle this. And thanks for the explanations.

@Thykof Thykof changed the title Push wails frontend generated files Push generated files Jul 21, 2023
@loonggamma
Copy link
Contributor

@Thykof we need to sync on this

@Thykof Thykof added this to the Mainnet ready - others milestone Sep 12, 2023
@Thykof
Copy link
Contributor

Thykof commented Sep 12, 2023

it relates to having the wallet plugin as a library to be used by a plugin builder (or operation spammer).

This could also be tackle to reduce technical dept or/and increase code quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants