Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

467 push generated files #468

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ASAPSegfault
Copy link
Contributor

No description provided.

@ASAPSegfault ASAPSegfault linked an issue Jun 27, 2023 that may be closed by this pull request
@ASAPSegfault ASAPSegfault marked this pull request as draft June 27, 2023 10:08
@Thykof
Copy link
Contributor

Thykof commented Jul 13, 2023

Why did you need that? to be able to import station-massa-wallet as a go package? We can push goswagger generated files for sure, but we need to find another trick for frontend generated file: push a .gitkeep file for example

@Thykof Thykof force-pushed the 467-push-wails-frontend-generated-files branch from 59b7734 to 72824c8 Compare July 21, 2023 12:11
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Thykof Thykof changed the title 467 push wails frontend generated files 467 push generated files Jul 21, 2023
@Thykof
Copy link
Contributor

Thykof commented Jul 21, 2023

  • I pushed go swagger generated files
  • I added .gitkeep file where go embed need files

The problem is that when we generate the frontends, it empty the dist directory, hence it remove the .gitkeep file.

@Thykof Thykof force-pushed the 467-push-wails-frontend-generated-files branch from 3861254 to e9f0630 Compare December 20, 2023 19:13
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec65869) 55.08% compared to head (e9f0630) 55.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #468   +/-   ##
=======================================
  Coverage   55.08%   55.08%           
=======================================
  Files          41       41           
  Lines        2371     2371           
=======================================
  Hits         1306     1306           
  Misses        890      890           
  Partials      175      175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 20, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push generated files
2 participants