bring over golang standards from CLI repo #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaketf
commented
Jul 8, 2022
jaketf
commented
- add pre-commit with golangci-lint
- refactor some error handling to define error "types" that can be wrapped with additional context.
chrisghill
approved these changes
Jul 9, 2022
| if tc.wantError != nil { | ||
| if err == nil { | ||
| t.Fatalf("Expected error: %s, got nil", tc.wantError.Error()) | ||
| } | ||
| if err.Error() != tc.wantError.Error() { | ||
| if !errors.Is(err, tc.wantError) { |
There was a problem hiding this comment.
Nice! I was looking for a better way to do this!
WillBeebe
approved these changes
Jul 10, 2022
Co-authored-by: Christopher Hill <chris@massdriver.cloud>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.