DP-19787: Fix the needs attention views #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calls to superset were calling a non-existant old view. In addition, the superset API has changed and this decreases the batch size from 1000 to 500 to eliminate timeouts.
tom-fleming
added a commit
that referenced
this pull request
Oct 20, 2020
* config change and changelog (#479) * DP 20094 help text change for data resource type field (#480) * help text changes * changelog * simple text change to trigger rebuild * changelog update and remove old changelog files * Add data fields to service_page (#474) * Add data fields to service_page * Use related terms * Add support for service_page in mass_related_terms token. * add field to be used for description * conditional logic and form layout changes * Fix coding standards. Co-authored-by: Joe Galluccio <joseph.galluccio@state.ma.us> * Remove balancer in Terraform (#481) * Remove balancer IP address. * Add changelog * try uppercase * Declare the variable again. Add logging * Remove super verbose logging. * Upper * Dp 20172 promo button text size (#486) * config changes * changelog * Add changelog (#485) * DP-19747 - Reduce log noise (#484) * Remove debug loggings. * Add changelog * CS * Fix doc comment. * bool * Update basic iframe URL so that node ID is correctly passed to Supers… (#483) * Update basic iframe URL so that node ID is correctly passed to Superset filter. * changelog. * fixing syntax on changelog Co-authored-by: joeg8612 <joseph.galluccio@state.ma.us> * DP-19787: Fix the needs attention views (#476) * DP-19787: Fix the needs attention views The calls to superset were calling a non-existant old view. In addition, the superset API has changed and this decreases the batch size from 1000 to 500 to eliminate timeouts. * DP-19787: Add changelog * DP-19787: Increase the cron timeout for superset queue items * DP-19787: Restart mass_superset queue * Added changelog - DP-19120 Co-authored-by: joeg8612 <joseph.galluccio@state.ma.us> Co-authored-by: CircleCI Deployment Bot <circleci@example.com> Co-authored-by: Moshe Weitzman <weitzman@tejasa.com> Co-authored-by: Yukiko Gannett <yukikogannett@gmail.com> Co-authored-by: adamcogbill <33554893+adamcogbill@users.noreply.github.com> Co-authored-by: Robert Stephens <roberttstephens@gmail.com>
ygannett
added a commit
that referenced
this pull request
Oct 20, 2020
* DP-19120: header navigation changes * Template changes * Adding changelog * Adding default conf * phpcs issue fix * adjust theming templates for additional changes done in Mayflower * DP-19328 Hamburgermenu for binder page (#406) * update the <head> content generation logic in /themes/custom/mass_theme/templates/layout/page--node--without-main.html.twig for binder page * add changelog for DP-19328 * remove commented out code * update the menu label change in Mayflower * match MF change in theming * DP-19876: Contextual login links are missing in branch with new global nav (#468) * DP-19876: Contextual links fix * DP-19876: Added changelog Co-authored-by: Tom Fleming <tom@lastcallmedia.com> * DP-20203 Missing alert overlay in info details page (#490) * add alert overlay container to page--node--without-main.html.twig * add changelog for DP-20203 * Added back header_mixed_urls setting - DP-19120 * Resolve DP-19120 merge conflicts (#492) * config change and changelog (#479) * DP 20094 help text change for data resource type field (#480) * help text changes * changelog * simple text change to trigger rebuild * changelog update and remove old changelog files * Add data fields to service_page (#474) * Add data fields to service_page * Use related terms * Add support for service_page in mass_related_terms token. * add field to be used for description * conditional logic and form layout changes * Fix coding standards. Co-authored-by: Joe Galluccio <joseph.galluccio@state.ma.us> * Remove balancer in Terraform (#481) * Remove balancer IP address. * Add changelog * try uppercase * Declare the variable again. Add logging * Remove super verbose logging. * Upper * Dp 20172 promo button text size (#486) * config changes * changelog * Add changelog (#485) * DP-19747 - Reduce log noise (#484) * Remove debug loggings. * Add changelog * CS * Fix doc comment. * bool * Update basic iframe URL so that node ID is correctly passed to Supers… (#483) * Update basic iframe URL so that node ID is correctly passed to Superset filter. * changelog. * fixing syntax on changelog Co-authored-by: joeg8612 <joseph.galluccio@state.ma.us> * DP-19787: Fix the needs attention views (#476) * DP-19787: Fix the needs attention views The calls to superset were calling a non-existant old view. In addition, the superset API has changed and this decreases the batch size from 1000 to 500 to eliminate timeouts. * DP-19787: Add changelog * DP-19787: Increase the cron timeout for superset queue items * DP-19787: Restart mass_superset queue * Added changelog - DP-19120 Co-authored-by: joeg8612 <joseph.galluccio@state.ma.us> Co-authored-by: CircleCI Deployment Bot <circleci@example.com> Co-authored-by: Moshe Weitzman <weitzman@tejasa.com> Co-authored-by: Yukiko Gannett <yukikogannett@gmail.com> Co-authored-by: adamcogbill <33554893+adamcogbill@users.noreply.github.com> Co-authored-by: Robert Stephens <roberttstephens@gmail.com> Co-authored-by: Yukiko Gannett <yukikogannett@gmail.com> Co-authored-by: Tom Fleming <tom@lastcallmedia.com> Co-authored-by: joeg8612 <joseph.galluccio@state.ma.us> Co-authored-by: CircleCI Deployment Bot <circleci@example.com> Co-authored-by: Moshe Weitzman <weitzman@tejasa.com> Co-authored-by: adamcogbill <33554893+adamcogbill@users.noreply.github.com> Co-authored-by: Robert Stephens <roberttstephens@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The needs attention dashboard/views haven't had any data since March 2020. This fixes the integration with superset. When cron runs the data will be queued and processed. While the data is processed, requests are made to superset. The data is then saved in the
mass_superset_datatable.The calls to superset were calling a non-existant old view. In addition, the superset API has changed and this decreases the batch size from 1000 to 500 to eliminate timeouts.
The cron is already set up in Acquia so nothing else should be necessary unless these queue items are unable to finish processing in the timeout. If that's the case, we could add an additional "scheduled job" in Acquia as well as an additional health check at healthchecks.io to process these queue items.
Jira: (Skip unless you are MA staff)
https://jira.mass.gov/browse/DP-19787
To Test:
URLs that show this data:
Steps:
$last_run,$in_window, etc.ahoy drush core:cronwhich will run the cron and process the items in the superset queue.ahoy drush cache:rebuild.Screenshots/GIFs:
Use something like licecap to capture gifs to demonstrate behaviors.
Peer Review Checklist