Update @mixin flex() to accomodate box-flex #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So the previous pull request mastastealth#11 was actually broken. The output of `@mixin flex()` when given a list wasn't filling out all the properties correctly. This PR should fix that, and ensure that all box-flex properties are filled out appropriately too! Now both, for example, `@include flex(10, 5, 100px)` and `@include flex(10 5 100px)` work!
|
Yeah, I went over this with @jeffkamo. My PR was bunk. This is much better! |
|
@mastastealth My PR was bad; this should get poked at as soon as possible. |
|
Sorry, currently on a trip and didn't catch this till now! |
mastastealth
added a commit
that referenced
this pull request
Mar 18, 2014
Update @mixin flex() to accomodate box-flex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the previous pull request #11 was actually broken.
The output of
@mixin flex()when given a list wasn't filling out all the properties correctly.This PR should fix that, and ensure that all box-flex properties are filled out appropriately too!
Now both, for example,
@include flex(10, 5, 100px)and@include flex(10 5 100px)work!