-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: roll instances + modify ASG sizes + add aqua #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
A couple of small comment + I suggest to update the default type to t4g.nano
. What do you think?
|
||
max_size = var.instance_count |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've never noticed that it's implemented like that. Good call 👍
main.tf
Outdated
desired_capacity = var.desired_capacity | ||
|
||
# We don't care to protect from scale in by default, as we want to roll instances frequently | ||
protect_from_scale_in = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is false by default.
What if we add a variable protect_from_scale_in
, and set it to false in case a user wants to protect an instance, AND add the attribute scale_in_protected_instances to aws_autoscaling_group
:
scale_in_protected_instances
- (Optional) Behavior when encountering instances protected from scale in are found. Available behaviors areRefresh
,Ignore
, andWait
. Default is Ignore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what
instance_count
variable and uses the actualdesired_capacity
,min_size
,max_size
variableswhy
references