Allow override of TLS certificate hostname #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When verifying a certificate that has been passed directly with the CACert field it is useful to be able to override the hostname without disabling any other certificate verification checks. For example: EC2 instances that are given a certificate during provisioning when the IP is not yet known and there will be no DNS entry.
masterzen
requested changes
May 24, 2017
endpoint.go
Outdated
| @@ -18,6 +18,8 @@ type Endpoint struct { | |||
| HTTPS bool | |||
| // set the flag true for skipping ssl verifications | |||
| Insecure bool | |||
| // if set, used to verify the hostname on the returned certificate | |||
| TLSServerName string | |||
There was a problem hiding this comment.
There seem to have a whitespace issue there, can you run make format, then rebase an repush to this PR ?
hoenirvili
approved these changes
May 24, 2017
|
Thank you for your contribution! |
masterzen
approved these changes
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When verifying a certificate that has been passed directly with the
CACert field it is useful to be able to override the hostname without
disabling any other certificate verification checks.
For example: EC2 instances that are given a certificate during
provisioning when the IP is not yet known and there will be no DNS
entry.