Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix garbage collection for the SpatioTemporalIndexImpRebuilderThread #14

Merged
merged 2 commits into from
May 31, 2023
Merged

Fix garbage collection for the SpatioTemporalIndexImpRebuilderThread #14

merged 2 commits into from
May 31, 2023

Conversation

maarzt
Copy link
Contributor

@maarzt maarzt commented May 25, 2023

This PR fixes a bug in the SpatioTemporalIndexImpRebuilderThread that prevented the SpatioTemporalIndexImp and hence the ModelGraph in Mastodon from beeing garbage collection. See issue mastodon-sc/mastodon#225.

The bug fixed in this PR was causing the following test to fail:

package org.mastodon.mamut.tomancak;

import org.junit.Test;
import org.mastodon.mamut.model.Model;

public class MastodonMemoryTest
{
	@Test
	public void test() {
		for ( int i = 0; i < 100; i++ )
		{
			new Model();
		}
	}
}

(Note: There are other bugs in Mastodon that need to be solved before mastodon-sc/mastodon#225 can be closed.)

@maarzt maarzt requested review from tpietzsch and tinevez May 25, 2023 09:02
@maarzt
Allow the garbage collection of the SpatialTemporalIndexImp
7f41fa5 
Previously the SpatialTemporalIndexImpRebuilderThread was holding a strong
reference to the SpatialTemporalIndexImp in its run method, at all time.
This prevented the spatial temporal index from being garbage collected,
which also meant that the thread never terminated.
@maarzt
SpatiTemporalIndexImpRebuilderThread: refactoring use Thread.sleep(ti…
0305a8e 
…meout)

The Thread previously used Object.wait(timeout) for waiting.
Object.wait(timeout) is part of complicated API for thread synchronization
which should be avoided.

Thread.sleep(timeout) is a simple replacement that works perfectly fine
for our use case.
@maarzt maarzt mentioned this pull request May 31, 2023
Merged
2 tasks
@maarzt maarzt merged commit ccacc4d into master May 31, 2023
1 check passed
@maarzt maarzt deleted the fix-garbage-collection branch May 31, 2023 14:31
This was referenced Jun 20, 2023
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinevez tinevez tinevez approved these changes

@tpietzsch tpietzsch Awaiting requested review from tpietzsch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maarzt @tinevez