allow external redis instance #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SISheogorath
approved these changes
Nov 30, 2022
deepy
approved these changes
Nov 30, 2022
|
@norman-zon Thank you for doing this :D! |
|
To save some folks some sanity trying to figure this out, it appears that this doesn't work in some cases where the external redis instance requires TLS (e.g. DigitalOcean's Managed Redis offering). This an unrelated issue, but will cause obscure errors as a result. Issue: mastodon/mastodon#19824 It may be possible to involve stunnel to resolve this issue in the interim, but setting that up is definitely outside the scope of this PR. |
pqo
pushed a commit
to pqo/chart
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the capability to use an external redis instance, instead of the bundled one, to the helm chart.
Replaces the PR in the mastodon main repo.