Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for the ONE_CLICK_SSO_LOGIN environment variable #1300

Merged
merged 1 commit into from Dec 5, 2023

Conversation

CSDUMMI
Copy link
Contributor

@CSDUMMI CSDUMMI commented Sep 12, 2023

Documents the environment variable added in mastodon/mastodon#26857

@vercel
Copy link

vercel bot commented Sep 12, 2023

@CSDUMMI is attempting to deploy a commit to the Mastodon Team on Vercel.

A member of the Team first needs to authorize it.

Enables the `Login or Register` button.
Useful for instances where all authentication takes place using a single
external provider (CAS, SAML or OIDC).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd mention that it may prevent the server from starting up if the OIDC server is not available, and also that it prevents caching of anonymous HTML pages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I added that the start up would only fail when using OIDC discovery, as the other authentication methods are unaffected.

@CSDUMMI CSDUMMI changed the title WIP: Add documentation for the ONE_CLICK_SSO_LOGIN environment variable Add documentation for the ONE_CLICK_SSO_LOGIN environment variable Sep 12, 2023
@CSDUMMI
Copy link
Contributor Author

CSDUMMI commented Oct 1, 2023

Is there something hindering the merging of this?

@vmstan
Copy link
Contributor

vmstan commented Dec 5, 2023

@andypiper this one looks good to merge

@andypiper andypiper merged commit 92c64fd into mastodon:master Dec 5, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants