Update admin install instructions for node 20

[audiodude]

Instructions taken from https://github.com/nodesource/distributions, which is where the scary message in the ttps://deb.nodesource.com/setup_16.x setup script directs you.

[vercel]

@audiodude is attempting to deploy a commit to the Mastodon Team on Vercel.

A member of the Team first needs to authorize it.

[vmstan]

The way you have it will install Node 20, but that's OK too.

[audiodude]

The way you have it will install Node 20, but that's OK too.

Oops, thought I edited that. Thanks for the review!

[ThisIsMissEm]

We actually expect Node 20 in 4.2.x, from the .nvmrc, so nodesource's node 20 is fine here.

[vmstan]

I think leaving it at 20 is ideal. That's where the Docker setup is at now.

[vmstan]

Fixes #1339

[vmstan]

I think we could remove these lines as they're part of the previous instruction in the doc

sudo apt-get update
 sudo apt-get install -y ca-certificates curl gnupg

We can also remove the sudo elevation from the instructions as they're already running as root here.

We could also just remove the NODE_MAJOR variable and set it as 20, to keep it clearer.

[audiodude]

I think we could remove these lines as they're part of the previous instruction in the doc

sudo apt-get update
 sudo apt-get install -y ca-certificates curl gnupg

We can also remove the sudo elevation from the instructions as they're already running as root here.

We could also just remove the NODE_MAJOR variable and set it as 20, to keep it clearer.

Updated, PTAL, thanks!

[vmstan]

There's still a couple sudo in the pipe commands.

[renchap]

I dont like nodejs being in the "System packages" section here, and I would prefer apt update && apt install -y nodejs to be in the "Node.js" section

[audiodude]

The only thing is that there is a section for nodejs, and a section for PostgreSQL. Both sections instruct you to install a package repository for the respective software. It seems incongruous that for PostgreSQL you would then install it as part of "system packages" but not nodejs?

[ThisIsMissEm]

We could perhaps add documentation about upgrading to a next major version of Node.js, as 22 will become active LTS in October 2024.

This requires changing the sources from:

echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_20.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list

to:

echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_22.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list

[vmstan]

We don't really target that yet though.

[ThisIsMissEm]

We don't really target that yet though.

Yeah, but it's more to say "You've gotta go back add edit your sources to get updated versions!"

[audiodude]

We could perhaps add documentation about upgrading to a next major version of Node.js, as 22 will become active LTS in October 2024.

This requires changing the sources from:

echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_20.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list

to:

echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_22.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list

I think this is outside of the scope of this PR.

[andypiper]

I'd prefer @renchap to review / merge this one (as I've not been through these steps myself).

[vmstan]

Good catch on the gpg location.