Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add credentials to trends + Error Handling for 401 #1107

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Add credentials to trends + Error Handling for 401 #1107

merged 3 commits into from
Aug 21, 2023

Conversation

zeitschlag
Copy link
Member

@zeitschlag zeitschlag commented Aug 21, 2023 •
edited

See #1104

To test simulate this:

  1. Make init in L. 17 in Mastodon+API+Error.swift public
  2. throw Mastodon.API.Error(httpResponseStatus: .unauthorized, mastodonError: nil) in DiscoveryPostsViewModel+State.swift, L.142, for example

@zeitschlag zeitschlag linked an issue Aug 21, 2023 that may be closed by this pull request
[BUG] The app does not supply credentials to /api/v1/trends/* routes in limited federation mode. #1104
Closed
1 task
@zeitschlag zeitschlag marked this pull request as ready for review August 21, 2023 11:30
@zeitschlag zeitschlag changed the title Add credentials to trends Add credentials to trends + Error Handling for 401 Aug 21, 2023
kimar
kimar approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@kimar kimar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 🚀

@zeitschlag zeitschlag merged commit ec162d9 into develop Aug 21, 2023
2 checks passed
@zeitschlag zeitschlag deleted the 1104-authenticated-trends branch August 21, 2023 12:36
@zeitschlag zeitschlag modified the milestone: 2023.12 Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimar kimar kimar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] The app does not supply credentials to /api/v1/trends/* routes in limited federation mode.
2 participants
@zeitschlag @kimar