Improve status updating mechanism #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitschlag
reviewed
Jan 21, 2024
zeitschlag
reviewed
Jan 23, 2024
MastodonSDK/Sources/MastodonCore/FetchedResultsController/StatusDataController.swift
Show resolved
Hide resolved
MastodonSDK/Sources/MastodonCore/FetchedResultsController/StatusDataController.swift
Show resolved
Hide resolved
MastodonSDK/Sources/MastodonCore/FetchedResultsController/StatusDataController.swift
Show resolved
Hide resolved
MastodonSDK/Sources/MastodonCore/DataController/FeedDataController.swift
Outdated
Show resolved
Hide resolved
Mastodon/Scene/Thread/MastodonStatusThreadViewModel+State.swift
Outdated
Show resolved
Hide resolved
zeitschlag
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Looks good great to me! 🚀
The last findings seem to work now, thank you very much for your work @kimar 🥳 💯
MastodonSDK/Sources/MastodonCore/DataController/FeedDataController.swift
Outdated
Show resolved
Hide resolved
MastodonSDK/Sources/MastodonCore/FetchedResultsController/StatusDataController.swift
Show resolved
Hide resolved
MastodonSDK/Sources/MastodonCore/DataController/FeedDataController.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The Status Refactoring PR removed the previous paradigm of how changes to the status data model are propagated throughout the app. This unfortunately also introduced bugs. This PR is making the status updates more transparent and fixes these bugs.