Add punycode support to the server search box #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Made by copy+pasting the pseudocode from the RFC and then changing it until it compiled
|
why is this PR not merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #429. I chose to only implement support for showing non-internationalized domains so I don’t have to wade into the issue of disambiguating forged domains (like
mаstodon.social/xn--mstodon-2fg.social). Still open is the question of how IDN domains on the official list will be handled. Ideally they’d be displayed in a more human-friendly way (since a human has verified that they’re not a scam) but that will have to be handled later when it actually happens.