Enable EN missing strings check

mastodon · May 11, 2024 · 4eb6abd · 4eb6abd
1 parent 6596de8
commit 4eb6abd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/.github/workflows/check-i18n.yml b/.github/workflows/check-i18n.yml
@@ -30,10 +30,5 @@ jobs:
           yarn i18n:extract --throws
           git diff --exit-code
 
-      - name: Check for missing strings in English YML
-        run: |
-          bundle exec i18n-tasks add-missing -l en
-          git diff --exit-code
-
       - name: Check that all required locale files exist
         run: bundle exec rake repo:check_locales_files
diff --git a/spec/locales/i18n_spec.rb b/spec/locales/i18n_spec.rb
@@ -5,17 +5,16 @@
 
 describe 'I18n' do
   # Copied from $(bundle exec i18n-tasks gem-path)/templates/rspec/i18n_spec.rb
-  describe I18n do
+  describe 'i18n-tasks' do
     let(:i18n) { I18n::Tasks::BaseTask.new }
-    let(:missing_keys) { i18n.missing_keys }
+    let(:missing_keys_en) { i18n.missing_keys(locale: 'en') }
     let(:unused_keys) { i18n.unused_keys }
     let(:inconsistent_interpolations) { i18n.inconsistent_interpolations }
 
-    # Fails because only EN files are currently enforced
-    # it 'does not have missing keys' do
-    #   expect(missing_keys).to be_empty,
-    #                           "Missing #{missing_keys.leaves.count} i18n keys, run `i18n-tasks missing' to show them"
-    # end
+    it 'does not have missing keys in English' do
+      expect(missing_keys_en).to be_empty,
+                                 "Missing #{missing_keys_en.leaves.count} i18n keys, run `i18n-tasks missing' to show them"
+    end
 
     it 'does not have unused keys' do
       expect(unused_keys).to be_empty,