Skip to content

Commit

Permalink
Change default KeyGenerator digest to SHA1 to fix cookies in rolling …
Browse files Browse the repository at this point in the history
…upgrades (#26023)
  • Loading branch information
ClearlyClaire committed Jul 21, 2023
1 parent e4ea80d commit 934c7b3
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion config/initializers/cookie_rotator.rb
@@ -1,14 +1,20 @@
# frozen_string_literal: true

# TODO: Remove after 4.2.0
Rails.application.configure do
config.active_support.key_generator_hash_digest_class = OpenSSL::Digest::SHA1
end

Rails.application.config.after_initialize do
Rails.application.config.action_dispatch.cookies_rotations.tap do |cookies|
authenticated_encrypted_cookie_salt = Rails.application.config.action_dispatch.authenticated_encrypted_cookie_salt
signed_cookie_salt = Rails.application.config.action_dispatch.signed_cookie_salt

secret_key_base = Rails.application.secret_key_base

# TODO: Switch to SHA1 after 4.2.0
key_generator = ActiveSupport::KeyGenerator.new(
secret_key_base, iterations: 1000, hash_digest_class: OpenSSL::Digest::SHA1
secret_key_base, iterations: 1000, hash_digest_class: OpenSSL::Digest::SHA256
)
key_len = ActiveSupport::MessageEncryptor.key_len

Expand Down

0 comments on commit 934c7b3

Please sign in to comment.