Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No push notification for poll results #10861

Closed
nolanlawson opened this issue May 27, 2019 · 0 comments · Fixed by #10864
Closed

No push notification for poll results #10861

nolanlawson opened this issue May 27, 2019 · 0 comments · Fixed by #10864
Labels
bug Something isn't working

Comments

@nolanlawson
Copy link
Contributor

nolanlawson commented May 27, 2019 •
edited

Notifications for poll results were added in #10209, but as far as I can tell, the push settings endpoint does not support poll as an option. It's also not listed in the API docs.

Expected behaviour

Tapping "push notifications" under "Poll results" should update the push subscriptions settings to include poll: true.

Actual behaviour

The PUT response indicates that you can't set a poll value.

Screenshot from 2019-05-27 12-21-11

Steps to reproduce the problem

  1. Go to notifications
  2. Tap the settings button
  3. Toggle "push notifications" under "Poll results"

Specifications

Mastodon v2.8.2. Chrome 74 on Android 6.0.1.
@nolanlawson nolanlawson added the bug Something isn't working label May 27, 2019
@nolanlawson nolanlawson mentioned this issue May 27, 2019
Closed
ClearlyClaire added a commit to ClearlyClaire/mastodon that referenced this issue May 27, 2019
@ClearlyClaire
Fix web push notifications for polls
e30ea63 
Fixes mastodon#10861
@ClearlyClaire ClearlyClaire mentioned this issue May 27, 2019
Merged
Gargron pushed a commit that referenced this issue May 27, 2019
@ClearlyClaire @Gargron
Fix web push notifications for polls (#10864)
fe3b863 
Fixes #10861
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this issue Oct 2, 2019
@ClearlyClaire @hiyuki2578
Fix web push notifications for polls (mastodon#10864)
0fd27c2 
Fixes mastodon#10861
rtucker pushed a commit to vulpineclub/mastodon that referenced this issue Jan 7, 2021
@ClearlyClaire
Fix web push notifications for polls (mastodon#10864)
556fedb 
Fixes mastodon#10861
@nolanlawson nolanlawson mentioned this issue Mar 14, 2021
Open
messenjahofchrist pushed a commit to Origin-Creative/mastodon that referenced this issue Jul 30, 2021
@ClearlyClaire @Gargron
Fix web push notifications for polls (mastodon#10864)
67dcb9c 
Fixes mastodon#10861
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix web push notifications for polls ClearlyClaire/mastodon
1 participant
@nolanlawson