Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin does not unpin #10945

Closed
rynnova opened this issue Jun 3, 2019 · 1 comment · Fixed by #10971
Closed

Unpin does not unpin #10945

rynnova opened this issue Jun 3, 2019 · 1 comment · Fixed by #10971

Comments

@rynnova
Copy link

rynnova commented Jun 3, 2019 •
edited

Expected behaviour

Unpin from profile should unpin a toot.

Actual behaviour

Pinned toot was left as pinned.

Steps to reproduce the problem

Toot.
Pin on profile the toot; toot should be pinned.
Unpin from profile the toot.
Click Getting started.
Click on your username to see your profile.
Toot is still pinned; no Unpin from profile option exists, but Pin on profile option does.

NOTE: If you refresh the page from the browser, the pin does remove itself from being pinned. This points to the issue existing in the React code.

Specifications

Mastodon v2.8.0
Windows 10
Firefox 67.0
ClearlyClaire added a commit to ClearlyClaire/mastodon that referenced this issue Jun 5, 2019
@ClearlyClaire
Fix refreshing featured toots when the new collection is empty
0ff9edc 
Fixes mastodon#10945
@ClearlyClaire ClearlyClaire mentioned this issue Jun 5, 2019
Merged
Gargron pushed a commit that referenced this issue Jun 5, 2019
@ClearlyClaire @Gargron
Fix refreshing featured toots when the new collection is empty (#10971)
d34a3a2 
Fixes #10945
@rynnova
Copy link
Author

rynnova commented Jun 5, 2019 •
edited

@Gargron Which version will this fix be available in? 2.8.5? Trying to let the admin of our instance know.

Also, where are my manners, thank you so much for fixing this so quickly!

hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this issue Oct 2, 2019
@ClearlyClaire @hiyuki2578
Fix refreshing featured toots when the new collection is empty (masto…
f7a8501 
…don#10971)

Fixes mastodon#10945
rtucker pushed a commit to vulpineclub/mastodon that referenced this issue Jan 7, 2021
@ClearlyClaire
Fix refreshing featured toots when the new collection is empty (masto…
43007ae 
…don#10971)

Fixes mastodon#10945
messenjahofchrist pushed a commit to Origin-Creative/mastodon that referenced this issue Jul 30, 2021
@ClearlyClaire @Gargron
Fix refreshing featured toots when the new collection is empty (masto…
2c1bb7d 
…don#10971)

Fixes mastodon#10945
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix refreshing featured toots when the new collection is empty ClearlyClaire/mastodon
1 participant
@rynnova