Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActivityPub 'Announce' sometimes not displayed correctly as 'Boost' #10950

Closed
vitalyster opened this issue Jun 4, 2019 · 1 comment · Fixed by #10967
Closed

ActivityPub 'Announce' sometimes not displayed correctly as 'Boost' #10950

vitalyster opened this issue Jun 4, 2019 · 1 comment · Fixed by #10967

Comments

@vitalyster
Copy link

vitalyster commented Jun 4, 2019

I'm sending something like this:

{"type":"Announce","id":"https://domain.tld/n/2944171-0#top","actor":"https://domain.tld/u/announcer","object":{"id":"https://domain.tld/n/2944171-0","published":"2019-06-04T07:51:33.779855Z","url":"https://domain.tld/m/2944171","to":["https://www.w3.org/ns/activitystreams#Public"],"content":"<p>text</p>","attributedTo":"https://domain.tld/u/poster","cc":["https://domain.tld/u/poster/followers/toc"],"type":"Note"},"type":"Announce","@context":["https://www.w3.org/ns/activitystreams","https://w3id.org/security/v1",{"Hashtag":"as:Hashtag"}]}

Expected behaviour

It should be displayed as "@announcer boosted message (@poster@domain.tld: Text)"

Actual behaviour

Sometimes it displayed correctly (I think its when @poster is already known to mastodon instance), sometimes it displayed as @announcer's(!) post, sometimes it displayed as "@announcer boosted @announcer's(!) post"

Specifications

I'm discovering my @announcer on mastodon.social instance, both poster and announcer are from another ActivityPub service.

@ClearlyClaire
Copy link
Contributor

What is this other ActivityPub service? It seems like this could happen if the announced object is inlined and lacks an attributedTo attribute, which is not the case of the AP snippet you posted.

I'm not sure whether we should assume a boosted status is from the booster when no attributedTo attribute is present… but when that's the case, we can't attribute it at all.

ClearlyClaire added a commit to ClearlyClaire/mastodon that referenced this issue Jun 4, 2019
Gargron pushed a commit that referenced this issue Jun 4, 2019
…10967)

* Do not misattribute inlined boosts if `attributedTo` isn't present

Fixes #10950

* Fix tests
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this issue Oct 2, 2019
…astodon#10967)

* Do not misattribute inlined boosts if `attributedTo` isn't present

Fixes mastodon#10950

* Fix tests
rtucker pushed a commit to vulpineclub/mastodon that referenced this issue Jan 7, 2021
…astodon#10967)

* Do not misattribute inlined boosts if `attributedTo` isn't present

Fixes mastodon#10950

* Fix tests
messenjahofchrist pushed a commit to Origin-Creative/mastodon that referenced this issue Jul 30, 2021
…astodon#10967)

* Do not misattribute inlined boosts if `attributedTo` isn't present

Fixes mastodon#10950

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants