Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add google cloud storage support in addition to S3 #1110

Closed
1 task done
nergdron opened this issue Apr 6, 2017 · 3 comments
Closed
1 task done

add google cloud storage support in addition to S3 #1110

nergdron opened this issue Apr 6, 2017 · 3 comments

Comments

@nergdron
Copy link

nergdron commented Apr 6, 2017

I see S3 support for shared media storage across multiple linked Mastodon instances. This is great! but it'd be nice to also have Google Cloud Storage support for running on their cloud / Kubernetes.


  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
@Gargron
Copy link
Member

Gargron commented Apr 7, 2017

Doesn't Google Cloud Storage have a S3-compatible API? In that case you simply need to specify S3_ENDPOINT

@nergdron
Copy link
Author

nergdron commented Apr 7, 2017

Ah, you're right! I didn't realize that! Should work fine, thank you!

@nergdron nergdron closed this as completed Apr 7, 2017
@jviide
Copy link
Contributor

jviide commented Apr 16, 2017

Sorry to resurrect an already closed issue, but it appears that Google Cloud Storage is having hard time with the "Expires" header set in config/initializers/paperclip.rb. Otherwise Google's S3 compatibility layer seems fine - changing the line

Paperclip::Attachment.default_options[:s3_headers]     = { 'Cache-Control' => 'max-age=315576000', 'Expires' => 10.years.from_now.httpdate }

to

Paperclip::Attachment.default_options[:s3_headers]     = { 'Cache-Control' => 'max-age=315576000' }

was enough to convince Google Cloud Storage to cooperate.

I created pull request #1886 for this, just in case if it's ok to drop the header.

abcang added a commit to pixiv/mastodon that referenced this issue Jun 5, 2018
…mprove_reply_tree

Revert "Revert "Improve reply tree""
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants