Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If not approved as a trend tag, hashtags that do not match exactly will not appear in the search results. #11960

Closed
orlea opened this issue Sep 26, 2019 · 7 comments · Fixed by #11977

Comments

@orlea
Copy link
Contributor

orlea commented Sep 26, 2019

I am running in the following environment.
mastodon v3.0.0rc1, no ElasticSearch

If not approved as a trend tag, hashtags that do not match exactly will not appear in the search results.
Example: When searching with #masto, only #masto is displayed in the search results.

In v2.9.3, partially matching tags were also displayed in the search results.
Example: Searching with #masto will show both #mastodon and #mastodev in the search results.

I think this is a feature that was changed in this commit.
cc0a55c

The trend tag feature is a good feature, but
It's painful to open the admin page every time you look for similar tags that you don't know when to come.
Ordinary users can't do anything.

I want a feature that is approved by default, or that the approval status does not affect the search results.

Mostly machine translation. Sorry for my poor English.

@Gargron
Copy link
Member

Gargron commented Sep 26, 2019

Appearing in search results is controlled by "listable" boolean + having been reviewed. It is not strictly bound to trends, but trends is when you would be asked to review a hashtag by the system.

The reason for only showing exact matches unless they are reviewed is that it's very easy to add inappropriate/harmful hashtags.

I am open to more feedback on this.

@tribela
Copy link
Contributor

tribela commented Sep 26, 2019

So, Minor tags that has not been trended are also not listed on search?
Maybe related, When I searched "#masto" on search bar, I don't get "mastodon" hashtag even that hashtag are in trend. So IMO I like the old behaviour

@Gargron
Copy link
Member

Gargron commented Sep 26, 2019

Exact matches are always returned. If you search for "ff", you get "ff", but you don't get "ff_kill_all_puppies" unless that one has been reviewed.

@tribela
Copy link
Contributor

tribela commented Sep 26, 2019

But only exact match are returned, that search function is not useful. (On a smaller instance, There is no trending tags)
I think listing inappropriate hashtag on search result is harmless (unlike trending)

@tribela
Copy link
Contributor

tribela commented Sep 26, 2019

Using ElasticSearch to index hashtags with edge n-grams and score
them by usage within the last 7 days since last activity.

If I understand correctly, which means old trended hashtags(eg, #comiccon_2014) are not listed on search?

@orlea
Copy link
Contributor Author

orlea commented Sep 26, 2019

On a smaller instance, There is no trending tags

This is really true.
So it becomes a disturbing function.
So We need a switch function of the approved tag function (whether it affects the search result at least).

@Gargron
Copy link
Member

Gargron commented Sep 27, 2019

Once again, it is not controlled by trends (trendable). It is controlled by listable + reviewed_at. You can review any hashtag at any time.

But, I realize this is a lot of work. Maybe reviewed_at requirement should go. But the problem is very real especially with autosuggest (which uses same API as search), for example, if you type "crea" going for "creativetoots", one of the top suggestions is a R18 keyword. Perhaps the requirement should be delegated to an API param, and remove the requirement from search form, but keep it in autosuggestions.

Gargron added a commit that referenced this issue Sep 27, 2019
Make it so normal search returns even unreviewed matches, but
autosuggestions do not.

Fix #11960
Gargron added a commit that referenced this issue Sep 27, 2019
Make it so normal search returns even unreviewed matches, but
autosuggestions do not.

Fix #11960
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this issue Oct 2, 2019
…odon#11977)

Make it so normal search returns even unreviewed matches, but
autosuggestions do not.

Fix mastodon#11960
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants