Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fav/star animation is jarring #12151

Closed
ariasuni opened this issue Oct 12, 2019 · 0 comments · Fixed by #12175
Closed

Fav/star animation is jarring #12151

ariasuni opened this issue Oct 12, 2019 · 0 comments · Fixed by #12175

Comments

@ariasuni
Copy link
Contributor

Expected behaviour

Star animation when un/fav-ing a toot is smooth.

Here’s a five minutes hack, that as you can see is perfectly smooth (it should be thrice as fast but somehow my recorder messed up the time):

Peek 12-10-2019 06-03

Done with this code:

@keyframes unfav {
    from { transform: rotate(0deg); }
    50%  { transform: rotate(-400deg); }
    to   { transform: rotate(-360deg); }
}

.fa-star {
    animation: unfav 2s ease 1s infinite;
}

Actual behaviour

output

The quality of the GIF may it looks slightly worse than it really is, but when using Mastodon I very often notice the shaking.

I guess it might work better by using CSS animation because then Firefox can plan all the frames instead of just reacting to the JavaScript increasing or decreasing the rotation’s angle.

Steps to reproduce the problem

Fav a toot in Firefox.

Specifications

Mastodon 3.0.1 but this bug is present since as far as I can remember so at least two years.

Arch Linux, Firefox Developer Edition 70b14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant