Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications fail to load #1491

Closed
1 task done
riking opened this issue Apr 11, 2017 · 16 comments
Closed
1 task done

Notifications fail to load #1491

riking opened this issue Apr 11, 2017 · 16 comments
Labels
bug Something isn't working expertise wanted Extra expertise is needed for implementation ui Front-end, design

Comments

@riking
Copy link

riking commented Apr 11, 2017 •
edited

Bad commit 12f72e1

application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:39
TypeError: status.getIn is not a function
    at Object.render (application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:30)
    at ReactCompositeComponentWrapper._renderValidatedComponentWithoutOwnerOrContext (application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:702)
    at ReactCompositeComponentWrapper._renderValidatedComponent (application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:702)
    at ReactCompositeComponentWrapper.performInitialMount (application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:702)
    at ReactCompositeComponentWrapper.mountComponent (application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:702)
    at Object.mountComponent (application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:1110)
    at ReactCompositeComponentWrapper.performInitialMount (application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:702)
    at ReactCompositeComponentWrapper.mountComponent (application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:702)
    at Object.mountComponent (application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:1110)
    at ReactCompositeComponentWrapper.performInitialMount (application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:702)
(anonymous) @ application-40ef2e74c5e2f7d364d4364f187e18e4b1cd3a785debb8a00a1532ba1e37b483.js:39
  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
@wxcafe
Copy link
Contributor

wxcafe commented Apr 11, 2017 •
edited

screenshot from 2017-04-11 01-57-15 Part of the nginx log that might be related, and

screenshot from 2017-04-11 01-37-59

console log in firefox.

Seems like other people have the same problem https://ohai.su/users/lutoma/updates/146

[EDIT] nginx is no longer showing me these errors and yet the problem persists

@wxcafe wxcafe added bug Something isn't working priority - high ui Front-end, design expertise wanted Extra expertise is needed for implementation labels Apr 11, 2017
@wxcafe
Copy link
Contributor

wxcafe commented Apr 11, 2017

This was following upgrading to master from v1.1.1. I basically followed the production guide:

  • services stop
  • git pull
  • rbenv install 2.4.1
  • gem install bundler
  • bundle install
  • RAILS_ENV=production bundle exec rails db:migrate
  • RAILS_ENV=production bundle exec rails assets:precompile
  • services start

@mjankowski
Copy link
Contributor

Possibly related commit (which is after 1.1.1) - 12f72e1

@wxcafe
Copy link
Contributor

wxcafe commented Apr 11, 2017

Rerolling to v1.1.1 AND downgrading the assets fixes it (I'm dumb)

riking referenced this issue Apr 11, 2017
@Gargron
When avatar/header are GIF, generate static versions (#1428)
12f72e1 
* When avatar/header are GIF, generate static versions.
Account API returns "avatar"/"avatar_static", "header"/"header_static"
Static version is the same as original for other cases
Web UI de-animates avatars in toots, lists of users

Fix #441, fix #596, prerequisite for #1064

* Fix JS test

* Add rake task to generate static avatars/headers from GIF ones, add test
@Gargron
Copy link
Member

Gargron commented Apr 11, 2017

Possibly introduced in 2810013 (unlikely that it's 12f72e1)

@riking
Copy link
Author

riking commented Apr 11, 2017 •
edited

Notifications were still streaming, and working in the Android app. Unlikely that a server change would do that.

And it seems I accidentally hid it, but the actual error is TypeError: status.getIn is not a function - I'm not sure how it could be anything else?

@riking riking mentioned this issue Apr 11, 2017
Closed
@Fastidious
Copy link

Fastidious commented Apr 11, 2017 •
edited

Same happening to my instance (“Ops! An unexpected error occurred.” message). Notifications are blank. Running latest master, dockerised.

@Wonderfall
Copy link
Contributor

Reverted to 0687ab8 and it works again.

@riking
Copy link
Author

riking commented Apr 11, 2017 •
edited

looking over my draft of an integration test #1499 , Follow notifications don't have a status - could that be it?

@Fusl
Copy link

Fusl commented Apr 11, 2017

@riking That seems to be the case. My notifications are loading until I scroll down to where the latest follow notification is at which point it stops loading and fails with the error TypeError: status.getIn is not a function.

@wxcafe wxcafe mentioned this issue Apr 11, 2017
Closed
1 task
@wxcafe wxcafe changed the title Notifications fail to load (social.wxcafe.net) Notifications fail to load Apr 11, 2017
@Fastidious
Copy link

Could someone post the temporary fix for this? Will a git revert 0687ab8 be the way to go? Please advise.

@wxcafe
Copy link
Contributor

wxcafe commented Apr 11, 2017

@Fastidious git checkout 0687ab8, RAILS_ENV=production bundle exec rails db:migrate, RAILS_ENV=production bundle exec rails assets:precompile, systemctl restart 'mastodon-*'

@Fastidious
Copy link

Fastidious commented Apr 11, 2017 •
edited

@wxcafe I am on Docker. For anyone wanting to temporarily fix this using Docker, the steps are:

  • git checkout 0687ab8
  • docker-compose build
  • docker-compose run --rm web rails db:migrate
  • docker-compose run --rm web rails assets:precompile
  • docker-compose up -d

@Fastidious Fastidious mentioned this issue Apr 11, 2017
Merged
@Gargron
Copy link
Member

Gargron commented Apr 11, 2017

I found the source of the issue, preparing a PR.

Gargron added a commit that referenced this issue Apr 11, 2017
@Gargron
Fix #1491 - Fix broken notifications, broken Link header parsing for …
ca5d879 
…exclude_types
@davidcelis davidcelis mentioned this issue Apr 11, 2017
Closed
1 task
@ericblade
Copy link
Contributor

fwiw, i'm only seeing it when i attempt to search something. will check out the fix.

@ericblade ericblade mentioned this issue Apr 11, 2017
Closed
@ericblade
Copy link
Contributor

appears to be fixed with that commit

ericblade pushed a commit to ericblade/mastodon that referenced this issue Apr 11, 2017
@Gargron
Fix mastodon#1491 - Fix broken notifications, broken Link header pars…
5d61fec 
…ing for exclude_types
@lumenwrites lumenwrites mentioned this issue Apr 12, 2017
Closed
1 task
Nyoho referenced this issue in Nyoho/mathtodon Apr 25, 2017
@Gargron
Fix #1491 - Fix broken notifications, broken Link header parsing for …
d07ca90 
…exclude_types (#1548)
ClearlyClaire added a commit to ClearlyClaire/mastodon that referenced this issue Jan 27, 2021
@ClearlyClaire
Merge pull request mastodon#1491 from ThibG/glitch-soc/merge-upstream
52ff3ca 
Merge upstream changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working expertise wanted Extra expertise is needed for implementation ui Front-end, design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@mjankowski @Gargron @riking @ericblade @Fusl @wxcafe @Wonderfall @Fastidious