Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not open the original toot from media page on mobile #15374

Closed
pullopen opened this issue Dec 19, 2020 · 1 comment · Fixed by #15417
Closed

Can not open the original toot from media page on mobile #15374

pullopen opened this issue Dec 19, 2020 · 1 comment · Fixed by #15417
Labels
bug Something isn't working

Comments

@pullopen
Copy link

Pitch

In the previous version, we can open the original toot if we open a media from someone's media page on mobile. But after v3.3.0rc1 it's gone and now we have no way to open the original toot.

Motivation

That would help us a lot with the context of a media.
@ClearlyClaire ClearlyClaire added the bug Something isn't working label Dec 19, 2020
@ClearlyClaire
Copy link
Contributor

Indeed, it's hidden on mobile from CSS:
https://github.com/tootsuite/mastodon/blob/c4e860277dbc391a0c6ec0311f66a8484cca862b/app/javascript/styles/mastodon/components.scss#L7203-L7205

I think it's not intentional but a side-effect of sharing the styling with the pop-out player thing.

ClearlyClaire added a commit to ClearlyClaire/mastodon that referenced this issue Dec 23, 2020
@ClearlyClaire
Fix media modal buttons not showing up on mobile
cbbf8bf 
Fixes mastodon#15374

When the pop-out player was introduced, it had tweaks for the mobile
view, but it's now disabled in mobile mode and the styling was reused
for modals, causing the footer to be hidden on mobile without a good
reason.
@ClearlyClaire ClearlyClaire mentioned this issue Dec 23, 2020
Merged
Gargron pushed a commit that referenced this issue Dec 23, 2020
@ClearlyClaire
Fix media modal buttons not showing up on mobile (#15417)
b08d2d4 
Fixes #15374

When the pop-out player was introduced, it had tweaks for the mobile
view, but it's now disabled in mobile mode and the styling was reused
for modals, causing the footer to be hidden on mobile without a good
reason.

Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix media modal buttons not showing up on mobile ClearlyClaire/mastodon
2 participants
@ClearlyClaire @pullopen