Add support for language preferences for trending statuses and links #18288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
added
the
new user experience
Gargron
force-pushed
the
feature-trending-statuses-language-fallbacks
branch
4 times, most recently
from
726ee08
to
a12834d
Compare
ykzts
approved these changes
Aug 27, 2022
Gargron
force-pushed
the
feature-trending-statuses-language-fallbacks
branch
3 times, most recently
from
541e6d1
to
38fbbb8
Compare
Gargron
changed the title
Gargron
force-pushed
the
feature-trending-statuses-language-fallbacks
branch
from
38fbbb8
to
8b77b74
Compare
Gargron
force-pushed
the
feature-trending-statuses-language-fallbacks
branch
from
8b77b74
to
2982d72
Compare
ClearlyClaire
requested changes
Oct 7, 2022
| else | ||
| scope.not_excluded_by_account(@account).not_domain_blocked_by_account(@account) | ||
| @locale |
There was a problem hiding this comment.
Shouldn't the @locale thing override chosen_languages?
There was a problem hiding this comment.
As per #19291 the preference takes precedence and allows seeing multiple languages.
There was a problem hiding this comment.
I guess it makes sense if @locale isn't something the user has direct/easy control on, but it's weird to have an API parameter ignored like that, it makes more sense to me that it would be an override than the opposite (e.g. if apps want to implement a language switch for popular posts).
Gargron
force-pushed
the
feature-trending-statuses-language-fallbacks
branch
from
2982d72
to
d4b207c
Compare
ClearlyClaire
approved these changes
Oct 8, 2022
|
Thanks, this will hopefully fix empty trends for Dutch and smaller languages on the landing page of e.g. mastodon.social (see screenshot). |
kadoshita
pushed a commit
to kadoshita/mastodon
that referenced
this pull request
Nov 19, 2022
nametoolong
pushed a commit
to nametoolong/nuage
that referenced
this pull request
Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of storing trends in a separate sorted Redis set for each language, store them all in a single table in the database. This allows querying by preferred languages but also including other languages.
When multiple languages are chosen in preferences, these are displayed at the top, otherwise, current content locale.
Instead asking moderators to review a trend only when it reaches a global threshold, which most languages can never do, it is now done for each language separately.
There is one regression, and that is that multiple posts by the same author can once again appear among trending statuses. Unfortunately I could not figure out how to best implement that.