Likes/Favs not properly streamed

[lfuelling]

Steps to reproduce the problem

How To Reproduce

1. Open Mastodon in a Browser
2. Get a reply to a post (or mentioned)
   • This will cause the notification to be streamed into the notifications
3. Open Mastodon in an App and like the status
4. Go back to the browser
   • The status in the notifications is not liked/faved until the page is refreshed

Expected behaviour

The like should be synced using the stream as well.

Actual behaviour

The like was not synced via streaming, I had to refresh the page.

Specifications

Mastodon: v3.5.3
Chrome: 103.0.5060.114
macOS: 12.4 (21F79)

[ThisIsMissEm]

This should be working, as Mastodon's Web UI connects to the user timeline in streaming. Could you re-test on a newer version of Mastodon? e.g., v4.1.x or even v4.2.0-rc1 ?

[ThisIsMissEm]

Actually, I think I've worked out what's happening: we're only sending the notification to the author of the status, not to the person performing the action. For reblogs you get this sync because it does a FeedManager#push_to_home which publishes the update via PushUpdateWorker; For favorites and others we'd need to do something similar where we push to the person doing the action.

[lfuelling]

This should be working, as Mastodon's Web UI connects to the user timeline in streaming. Could you re-test on a newer version of Mastodon? e.g., v4.1.x or even v4.2.0-rc1 ?

I can't. I'm not using Mastodon anymore, sorry.

[ThisIsMissEm]

@ClearlyClaire is this something we should fix? Feels like a maybe?