Federated Create->Image activities do not render the image inline

[wmurphyrd]

Steps to reproduce the problem

I would like to see the image content of an Image ActivityPub object render in my Mastodon timeline. I see in the Mastodon documentation that Image type payloads are listed as supported.

However, I only see the following in my mastodon.social Web client:

It seems Mastodon does understand the object and is able to discover the url to the actual png file, so why doesn't it render inline? Is there something different I could be doing with the activity structure? This is coming from an immers server using activitypub-express library

This post is publicly available as HTML or application/activity+json at https://immers.space/s/6340840eb21e584a50095cbf

JSON content below:

{
   "@context" : [
      "https://www.w3.org/ns/activitystreams",
      "https://w3id.org/security/v1",
      {
         "@context" : {
            "Model" : "is:Model",
            "avatar" : {
               "@id" : "is:avatar",
               "@type" : "@id"
            },
            "is" : "https://immers.space/ns/v1#"
         }
      }
   ],
   "actor" : "https://immers.space/u/datatitian",
   "id" : "https://immers.space/s/6340840eb21e584a50095cbf",
   "likes" : {
      "first" : "https://immers.space/likes/6340840eb21e584a50095cbe/?page=true",
      "id" : "https://immers.space/likes/6340840eb21e584a50095cbe/",
      "totalItems" : 0,
      "type" : "OrderedCollection"
   },
   "object" : {
      "attributedTo" : "https://immers.space/u/datatitian",
      "context" : {
         "audience" : [],
         "name" : "Infinite Worlds - Volcano #284 - from Immers Space",
         "type" : "Place",
         "url" : "https://infinite-worlds.glitch.me/?preset=egypt&seed=35"
      },
      "id" : "https://immers.space/o/6340840eb21e584a50095cbd",
      "to" : [
         "https://immers.space/followers/datatitian",
         "as:Public"
      ],
      "type" : "Image",
      "url" : {
         "href" : "https://immers.space/media/7c081125d7d83dcc10a268962059a80d",
         "mediaType" : "image/png",
         "type" : "Link"
      }
   },
   "published" : "2022-10-07T19:54:54.511Z",
   "shares" : {
      "first" : "https://immers.space/shares/6340840eb21e584a50095cbe/?page=true",
      "id" : "https://immers.space/shares/6340840eb21e584a50095cbe/",
      "totalItems" : 0,
      "type" : "OrderedCollection"
   },
   "to" : [
      "https://immers.space/followers/datatitian",
      "as:Public"
   ],
   "type" : "Create"
}

Expected behaviour

See the png image rendered in the timeline

Actual behaviour

See only its url

Specifications

Mastodon Web Client in Firefox on mastodon.social at v3.5.3

[trwnh]

It is true that Create Image is understood, but it is a second-class activity and will be transformed per the rules listed in the linked docs:

Some other Object types are converted as best as possible. The transformer uses content if available, or name if not, in order to generate status text. The url will be appended. [...]

Yes, it would be better to have a special transformer for Create Image. It just hasn't been done yet, probably because you would end up needing to a new transformer for each media type (Audio, Video, Image)

[wmurphyrd]

Would Mastodon accept a PR that transformed the url to be read as an attachment for the supported media object types?

[trwnh]

i dont see why not, but i can't say for sure

…

On Sun, Oct 16, 2022, 8:49 PM Will Murphy ***@***.***> wrote: Would Mastodon accept a PR that transformed the url to be read as an attachment for the supported media object types? — Reply to this email directly, view it on GitHub <#19357 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACQ5OX4CE5HXYYUXHZX2JBTWDSWC3ANCNFSM6AAAAAARFN4VAA> . You are receiving this because you commented.Message ID: ***@***.***>

[wmurphyrd]

Is it possible to get a maintainer to weigh in before committing the time to it?

Looks like it would be pretty simple, just have ActivityPub::Activity::Create.process_attachments check @object['url'] for attachments when converted_object_type is true