Mastodon will highly delay fetching media on edited posts

[kescherCode]

Steps to reproduce the problem

1. Make a post on a remote instance
2. Fetch it on mastodon.social or any other Mastodon instance (or have it federated to you)
3. Edit the post on the remote instance, deleting and reuploading either the same image or a different one (doesn't matter) and perhaps changing the image description
4. Fetch the post again (or have it federated to you)
   ...

Expected behaviour

The image showing up

Actual behaviour

The image is shown as a remote link, or as an empty image in apps as the media_proxy fails to fetch it for several attempts

Detailed description

No response

Specifications

51a33ce

[kescherCode]

I originally intended to title this "will not fetch media on edited post" because it really takes a while. The instance was not busy with other processing either, and this happens consistently on edited posts.

[rrgeorge]

In my experience it never fetches media for posts where the media was added/changed in the edit.

[kescherCode]

@rrgeorge I was under that same inpression shortly before sending the issue, but then I noticed "wait, that post now has media again. What is going on?"

[rrgeorge]

@rrgeorge I was under that same inpression shortly before sending the issue, but then I noticed "wait, that post now has media again. What is going on?"

Are you sure it wasn’t after your media retention would’ve switched it to on-demand?

I have a post I’m looking at that was edited 40 mins ago to add media, that says “Not Available”. I’ll keep looking at it periodically to see if it ever shows up…

[kescherCode]

@rrgeorge media retention on-demand? no, mine's set to 180 days.

[rrgeorge]

I see. It seems to update the media after an hour.

[ClearlyClaire]

Fixed by #21565