Fix attachments of edited statuses not being fetched #21565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
force-pushed
the
fixes/process-update-download-media-attachments
branch
from
74c1ae8
to
116f745
Compare
ykzts
approved these changes
Nov 25, 2022
Gargron
approved these changes
Nov 27, 2022
Closed
nametoolong
pushed a commit
to nametoolong/nuage
that referenced
this pull request
Jan 12, 2023
* Fix attachments of edited statuses not being fetched * Fix tests
ClearlyClaire
added a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Feb 9, 2023
* Fix attachments of edited statuses not being fetched * Fix tests
ClearlyClaire
added a commit
that referenced
this pull request
Feb 9, 2023
atsu1125
pushed a commit
to atsu1125/mastodon
that referenced
this pull request
Feb 17, 2023
…mastodon#23485) * Fix attachments of edited statuses not being fetched * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloading new media attachments would often fail because
RedownloadMediaWorker#performwould execute before the transaction gets committed to the database.I decided to make it fetch the attachments synchronously to mirror the behavior of status creation, since
ActivityPub::ProcessStatusUpdateServiceis called in similar contexts.