Fix unbounded recursion in account discovery #22025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykzts
approved these changes
Dec 4, 2022
unarist
approved these changes
Dec 4, 2022
This was referenced Dec 4, 2022
zunda
approved these changes
Dec 4, 2022
Deauthorized
suggested changes
Dec 4, 2022
There was a problem hiding this comment.
Regarding the lint errors for parameter lists being longer than 5 parameters, maybe this could be applied towards it?
https://codereview.stackexchange.com/questions/200298/parameter-list-too-long-in-initialize-method
ClearlyClaire
force-pushed
the
fixes/unbounded-recursion
branch
from
457af62
to
de8a6d5
Compare
I honestly would prefer if we switched |
|
If it helps I've manually merged this to my own instance on www dot omeowgle dot com and can help provide logs or anything if additional testing is needed (it's a small single user instance for my cat). |
maa123
pushed a commit
to maa123/mastodon
that referenced
this pull request
Dec 7, 2022
* Fix trying to fetch posts from other users when fetching featured posts * Rate-limit discovery of new subdomains * Put a limit on recursively discovering new accounts
perillamint
pushed a commit
to CyberSiliconForest/mastodon
that referenced
this pull request
Dec 10, 2022
* Fix trying to fetch posts from other users when fetching featured posts * Rate-limit discovery of new subdomains * Put a limit on recursively discovering new accounts
perillamint
pushed a commit
to kurry-social/mastodon
that referenced
this pull request
Dec 10, 2022
* Fix trying to fetch posts from other users when fetching featured posts * Rate-limit discovery of new subdomains * Put a limit on recursively discovering new accounts
perillamint
referenced
this pull request
in uri-life/mastodon
Dec 10, 2022
* Fix trying to fetch posts from other users when fetching featured posts * Rate-limit discovery of new subdomains * Put a limit on recursively discovering new accounts
PeterCxy
pushed a commit
to PeterCxy/mastodon
that referenced
this pull request
Dec 10, 2022
* Fix trying to fetch posts from other users when fetching featured posts * Rate-limit discovery of new subdomains * Put a limit on recursively discovering new accounts
nametoolong
pushed a commit
to nametoolong/nuage
that referenced
this pull request
Jan 12, 2023
* Fix trying to fetch posts from other users when fetching featured posts * Rate-limit discovery of new subdomains * Put a limit on recursively discovering new accounts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.