Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing instance-wide domain block .csv fails without reason if "limit" is used not "silence" #22958

Closed
meldra opened this issue Jan 6, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@meldra
Copy link

meldra commented Jan 6, 2023

Steps to reproduce the problem

  1. Decide to block/limit a bunch of instances at once.
  2. Cry at the prospect of doing all these one at a time and instead compile (seemingly) valid .csv to import
  3. Not realize that "limit" is called "silence" in the backend because you've never seen that used, so you specify limited instances with "limit"
  4. Try import this home-baked .csv into the federation table
    ...

Expected behaviour

At minimum, there should be an error given in the UI about what is wrong with the .csv

Actual behaviour

errorphant page

Detailed description

More than 2 of us, across 2 instances, spent all of last night trying to figure what the .csv import was upset about, without access to wherever the server logs this to.

Specifications

Mastodon 4.0.2+glitch
Ruby 3.0.4p208
PostgreSQL 14.6
Redis 6.0.16

@meldra meldra added the bug Something isn't working label Jan 6, 2023
@ClearlyClaire
Copy link
Contributor

Oh, I had expected something like this to fail as a validation error, not fail as spectacularly.

That can easily be fixed, but the current behavior is to ignore lines that have validation errors, so if that were the case, it would have showed as if you tried to import 0 domains… that doesn't sound too helpful either, I'm trying to think about how to improve that.

@ClearlyClaire
Copy link
Contributor

Would something like this work?

image

@meldra
Copy link
Author

meldra commented Jan 6, 2023

that's great! honestly anything other than the errorphant is an improvement

@ClearlyClaire
Copy link
Contributor

ok, #21470 should address it then!

@vmstan vmstan closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants