Change domain block CSV parsing to be more robust and handle more lists #21470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
force-pushed
the
fixes/domain-block-import-parsing
branch
from
d978557
to
23e6e35
Compare
ClearlyClaire
force-pushed
the
fixes/domain-block-import-parsing
branch
from
23e6e35
to
7e09675
Compare
15 tasks
Gargron
approved these changes
Jan 18, 2023
btrd
pushed a commit
to btrd/mastodon
that referenced
this pull request
Feb 22, 2023
…ts (mastodon#21470) * Change domain block CSV parsing to be more robust and handle more lists * Add some tests * Improve domain block import validation and reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #20597
Improve error handling, and make it handle list of domains without headers or additional data.
Also display validation errors and invalid arguments:
