Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change class of "ALT" tag to make it blockable #24969

Closed
mcclure opened this issue May 12, 2023 · 0 comments · Fixed by #28777
Closed

Change class of "ALT" tag to make it blockable #24969

mcclure opened this issue May 12, 2023 · 0 comments · Fixed by #28777
Labels
area/web interface Related to the Mastodon web interface suggestion Feature suggestion

Comments

@mcclure
Copy link

mcclure commented May 12, 2023

Steps to reproduce the problem

A recent change added a "ALT" badge to all images with alt text. I personally find this annoying¹.

I would like to use a CSS userstyle to remove the "alt" badge on my personal machine. However, there is a problem: The alt badge uses class .media-gallery__gifv__label. This means I cannot block the "alt" badge without also blocking the "gif" badge (which I find useful). The userstyle I wrote therefore is awkward and brittle (if the layout changes significantly it will stop working, and it does not work on Firefox without special settings) because it has to indirectly intuit which of the badges is the ALT one.

Expected behaviour

Reserve .media-gallery__gifv__label for the GIF label and use .media-gallery__altv__label or something for the alt label.

Detailed description

This will not create problems for people that want to create custom styles for all image badges because they can just use .media-gallery__item__badges span.

Specifications

mastodon.social ( v4.1.2+nightly-20230508) on current chrome


¹ The reasons I dislike the alt badge are probably not relevant because I am not requesting it be removed, only that it get a CSS class so it can be hidden / custom-styled on individual machines. But, the alt badge bothers me for two reasons; One, I feel like you are penalizing me for including alt text in my images, by partially obscuring the images (with a banner that, while small, may cover up content such as text). Two, I find the "alt" badge distracting to look at. If the alt badge were an interactive element as it is in some websites/apps, this would justify it better, but I would still personally want to hide it.

@mcclure mcclure added the bug Something isn't working label May 12, 2023
@vmstan vmstan added suggestion Feature suggestion area/web interface Related to the Mastodon web interface and removed bug Something isn't working labels Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web interface Related to the Mastodon web interface suggestion Feature suggestion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants