Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User is redirected to /explore after signing in #25600

Closed
renchap opened this issue Jun 26, 2023 · 3 comments · Fixed by #26143
Closed

User is redirected to /explore after signing in #25600

renchap opened this issue Jun 26, 2023 · 3 comments · Fixed by #26143
Labels
bug Something isn't working status/confirmed This bug has been confirmed
Milestone

Comments

@renchap
Copy link
Sponsor Member

renchap commented Jun 26, 2023

Steps to reproduce the problem

  1. Open a private browsing session on mastodon.social
  2. Sign-in with an existing account

Expected behaviour

I am redirected to my personal timeline after logging in

Actual behaviour

I am redirected to /explore

Detailed description

This might come from #25396

Specifications

Mastodon edge on mastodon.social

@renchap renchap added bug Something isn't working status/confirmed This bug has been confirmed labels Jun 26, 2023
@Signez
Copy link
Sponsor Contributor

Signez commented Jul 11, 2023

Narrowing down the bug: it's not that we are redirected to /explore on login, it's that we are redirected to the page we were before clicking on the button to sign-in.

If you open https://mastodon.social/home in a private browsing session, the page will show up with an empty state in the main column, and if you login, you will be redirected correctly to /home.

Should we force the redirection on /home only if we were on /explore before signing in? …or should we do it in any cases, which can create confusion or frustration if we were on a specific post?

@ClearlyClaire
Copy link
Contributor

I think it makes sense to redirect to /home if the newly-logged-in user would otherwise be redirected to what can be a logged-out landing page: /about, /explore… or the single user's profile on single-user instances… that one may be a bit more tricky

@renchap renchap added this to the 4.2.0 milestone Jul 21, 2023
@ClearlyClaire
Copy link
Contributor

Actually we already have that kind of logic, it was just not updated with the addition of the explore page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status/confirmed This bug has been confirmed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants