Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The onboarding quotas are completely arbitrary #27362

Closed
Oreolek opened this issue Oct 10, 2023 · 5 comments · Fixed by #27466
Closed

The onboarding quotas are completely arbitrary #27362

Oreolek opened this issue Oct 10, 2023 · 5 comments · Fixed by #27466
Labels
area/web interface Related to the Mastodon web interface bug Something isn't working

Comments

@Oreolek
Copy link

Oreolek commented Oct 10, 2023 •
edited

Steps to reproduce the problem

(This is about the prompt introduced in #25267)

The prompt pops up when the home feed is not going fast enough. Problem is, I'm subscribed to English speakers - geographically mostly American and European. There is a clear lull hour, about 1pm GMT, when Americans are still sleepy and Europeans just don't post much, so the home feed is stalling.

Expected behaviour

do not show this text for people who already know how to subscribe

Actual behaviour

i see the toast

Detailed description

My account is 6 years old, I'm subscribed to 900+ accounts, I'm perfectly fine catching up with the old posts. And every day, about the same time, I see this piece of condescending foolishness.

1

Mastodon instance

icosahedron.website

Mastodon version

v4.2.0

Browser name and version

Librewolf 118

Operating system

Arch Linux

Technical details

No response
@Oreolek Oreolek added area/web interface Related to the Mastodon web interface bug Something isn't working status/to triage This issue needs to be triaged labels Oct 10, 2023
@ClearlyClaire
Copy link
Contributor

Hi! You should be able to click the cross to dismiss that banner for good.

@Oreolek
Copy link
Author

Oreolek commented Oct 12, 2023 •
edited

Okay, here's another thing: see the "1 new item" below on the screenshot? When it goes to about 2 or 3, the popup hides itself along with the cross button. So I have to be quick enough to dismiss or it will nag me again. So far, I was not quick enough.

(Yes, this is ironic because after first several popups I wanted to screenshot it first and dismiss later and lost it again.)

@ClearlyClaire
Copy link
Contributor

Ah, there might also be inconsistent handling of slow mode, I'll try to look into it!

@vmstan vmstan removed the status/to triage This issue needs to be triaged label Oct 13, 2023
@ClearlyClaire ClearlyClaire mentioned this issue Oct 18, 2023
Closed
lambda pushed a commit to lambda/mastodon that referenced this issue Oct 19, 2023
Consider shown and pending status in explore prompt calculation
2f3e332 
The explore prompt had been picking between shown and pending statuses
when deciding whether to display the explore prompt, which prompts you
to follow more people if your timeline is not very busy.

Considering just the pending statuses would mean that sometimes, if you
had posted something which was now a pending status, that would be
filtered out (as the explore prompt calculation filters out our own
status) leaving no statuses, and thus show the explore prompt, even if
there is plenty of activity in the shown statuses.

Instead, we should be considering the first 20 of both the pending and
shown statuses for this computation; we need to concatenate the lists.

Fixes mastodon#27197, fixes mastodon#27362
@lambda lambda mentioned this issue Oct 19, 2023
Merged
@lambda
Copy link
Contributor

lambda commented Oct 19, 2023

I suspect that this might be the same issue that I tracked down in #27197, and submitted PR #27466 for. Can you check to see if you can reproduce it the same way, by posting your own status which shows up in the "1 new item" pending statuses, and causes the explore prompt to pop up?

@ClearlyClaire
Copy link
Contributor

Yes, I can confirm the issue, and also that it is addressed by your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/web interface Related to the Mastodon web interface bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consider shown and pending status in explore prompt calculation lambda/mastodon
4 participants
@lambda @Oreolek @ClearlyClaire @vmstan