Reduce factory creation in spec/models/account_statuses_cleanup_policy
#28361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renchap
added
refactoring
|
This pull request has merge conflicts that must be resolved before it can be merged. |
mjankowski
force-pushed
the
reduce-factories-spec-models-cleanup
branch
from
15b2ff2
to
faceb71
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
mjankowski
force-pushed
the
reduce-factories-spec-models-cleanup
branch
from
faceb71
to
5a0eae4
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
mjankowski
force-pushed
the
reduce-factories-spec-models-cleanup
branch
from
90076a7
to
3b187cd
Compare
mjankowski
force-pushed
the
reduce-factories-spec-models-cleanup
branch
2 times, most recently
from
95860f0
to
ef8a662
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
mjankowski
force-pushed
the
reduce-factories-spec-models-cleanup
branch
from
ef8a662
to
cc74ebb
Compare
ClearlyClaire
approved these changes
Jan 25, 2024
neatchee
pushed a commit
to neatchee/mastodon
that referenced
this pull request
Feb 4, 2024
* Add confirmation when redirecting logged-out requests to permalink (mastodon#27792) Co-authored-by: Claire <claire.github-309c@sitedethib.com> * chore(deps): update dependency rubocop to v1.60.1 (mastodon#28731) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix `Rails/WhereExists` cop in app/lib (mastodon#28862) * Use active variants for boost icons and increase icon size (mastodon#27924) * chore(deps): update dependency haml_lint to v0.55.0 (mastodon#28856) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency selenium-webdriver to v4.17.0 (mastodon#28858) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update artifact actions (major) to v4 (major) (mastodon#28415) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency dotenv to v16.4.0 (mastodon#28872) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency chewy to v7.5.0 (mastodon#28730) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Tidy up association declaration in `Instance` model (mastodon#28880) * Fix process of receiving posts with bearcaps is not working (mastodon#26527) * Fix redirect confirmation for accounts (mastodon#28902) * Add tests for redirect confirmations (mastodon#28903) * Add tests for processing statuses using bearcap URIs (mastodon#28904) * chore(deps): update dependency rspec-rails to v6.1.1 (mastodon#28905) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency axios to v1.6.6 (mastodon#28895) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix remaining `Rails/WhereExists` cop violations, regenerate todo (mastodon#28892) * fix(deps): update dependency dotenv to v16.4.1 (mastodon#28889) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Add `CustomFilterKeyword#to_regex` method (mastodon#28893) * New Crowdin Translations (automated) (mastodon#28899) Co-authored-by: GitHub Actions <noreply@github.com> * Consolidate db test prep steps to rake task (mastodon#28886) * Fix `Style/TernaryParentheses` cop (mastodon#28387) * Reduce factory creation in `spec/models/account_statuses_cleanup_policy` (mastodon#28361) * Extract helper methods for db connection and table existence check in `CLI::Maintenance` task (mastodon#28281) * Refactor conversations components in web UI (mastodon#28833) Co-authored-by: Claire <claire.github-309c@sitedethib.com> * Fix `Style/GuardClause` cop in app/controllers (mastodon#28420) * Update paperclip and climate_control gems (mastodon#28379) * Extract `rebuild_index` method in maintenance CLI (mastodon#28911) * Add specs for `Instance` model scopes and add `with_domain_follows` scope (mastodon#28767) * [Glitch] Add confirmation when redirecting logged-out requests to permalink Port SCSS changes from b19ae52 to glitch-soc Co-authored-by: Claire <claire.github-309c@sitedethib.com> Signed-off-by: Claire <claire.github-309c@sitedethib.com> * [Glitch] Use active variants for boost icons and increase icon size Port 5a838ce to glitch-soc Signed-off-by: Claire <claire.github-309c@sitedethib.com> * Fix CSS loading in redirect controller * [Glitch] Refactor conversations components in web UI (glitch-soc#2589) Port 3205a65 to glitch-soc Signed-off-by: Claire <claire.github-309c@sitedethib.com> Co-authored-by: Eugen Rochko <eugen@zeonfederated.com> * Fix crash in private mention conversations in glitch-soc flavor (glitch-soc#2595) * Remove obsolete locale file (glitch-soc#2596) * Add github action workflow for manual security builds (mastodon#29040) * Adapt workflow to glitch-soc * Fix missing `workflow_dispatch` trigger for `build-security` (mastodon#29041) * Configure selenium to use Chrome version 120 (mastodon#29038) * Fix security builds not being marked latest * Merge pull request from GHSA-3fjr-858r-92rw * Fix insufficient origin validation * Bump version to 4.3.0-alpha.1 * Fix build-security workflow for glitch-soc * Restore -streaming suffix for security builds (glitch-soc#2602) * Temporary hack to correctly tag the security docker image… * Fix build-security docker tags * fix lint issues in conversation.jsx --------- Signed-off-by: Claire <claire.github-309c@sitedethib.com> Co-authored-by: Eugen Rochko <eugen@zeonfederated.com> Co-authored-by: Claire <claire.github-309c@sitedethib.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Matt Jankowski <matt@jankowski.online> Co-authored-by: KMY（雪あすか） <tt@kmycode.net> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: Aaron Brady <aaron@insom.me.uk>
neatchee
added a commit
to neatchee/mastodon
that referenced
this pull request
Feb 4, 2024
* Add confirmation when redirecting logged-out requests to permalink (mastodon#27792) Co-authored-by: Claire <claire.github-309c@sitedethib.com> * chore(deps): update dependency rubocop to v1.60.1 (mastodon#28731) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix `Rails/WhereExists` cop in app/lib (mastodon#28862) * Use active variants for boost icons and increase icon size (mastodon#27924) * chore(deps): update dependency haml_lint to v0.55.0 (mastodon#28856) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency selenium-webdriver to v4.17.0 (mastodon#28858) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update artifact actions (major) to v4 (major) (mastodon#28415) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency dotenv to v16.4.0 (mastodon#28872) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency chewy to v7.5.0 (mastodon#28730) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Tidy up association declaration in `Instance` model (mastodon#28880) * Fix process of receiving posts with bearcaps is not working (mastodon#26527) * Fix redirect confirmation for accounts (mastodon#28902) * Add tests for redirect confirmations (mastodon#28903) * Add tests for processing statuses using bearcap URIs (mastodon#28904) * chore(deps): update dependency rspec-rails to v6.1.1 (mastodon#28905) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency axios to v1.6.6 (mastodon#28895) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix remaining `Rails/WhereExists` cop violations, regenerate todo (mastodon#28892) * fix(deps): update dependency dotenv to v16.4.1 (mastodon#28889) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Add `CustomFilterKeyword#to_regex` method (mastodon#28893) * New Crowdin Translations (automated) (mastodon#28899) Co-authored-by: GitHub Actions <noreply@github.com> * Consolidate db test prep steps to rake task (mastodon#28886) * Fix `Style/TernaryParentheses` cop (mastodon#28387) * Reduce factory creation in `spec/models/account_statuses_cleanup_policy` (mastodon#28361) * Extract helper methods for db connection and table existence check in `CLI::Maintenance` task (mastodon#28281) * Refactor conversations components in web UI (mastodon#28833) Co-authored-by: Claire <claire.github-309c@sitedethib.com> * Fix `Style/GuardClause` cop in app/controllers (mastodon#28420) * Update paperclip and climate_control gems (mastodon#28379) * Extract `rebuild_index` method in maintenance CLI (mastodon#28911) * Add specs for `Instance` model scopes and add `with_domain_follows` scope (mastodon#28767) * [Glitch] Add confirmation when redirecting logged-out requests to permalink Port SCSS changes from b19ae52 to glitch-soc Co-authored-by: Claire <claire.github-309c@sitedethib.com> Signed-off-by: Claire <claire.github-309c@sitedethib.com> * [Glitch] Use active variants for boost icons and increase icon size Port 5a838ce to glitch-soc Signed-off-by: Claire <claire.github-309c@sitedethib.com> * Fix CSS loading in redirect controller * [Glitch] Refactor conversations components in web UI (glitch-soc#2589) Port 3205a65 to glitch-soc Signed-off-by: Claire <claire.github-309c@sitedethib.com> Co-authored-by: Eugen Rochko <eugen@zeonfederated.com> * Fix crash in private mention conversations in glitch-soc flavor (glitch-soc#2595) * Remove obsolete locale file (glitch-soc#2596) * Add github action workflow for manual security builds (mastodon#29040) * Adapt workflow to glitch-soc * Fix missing `workflow_dispatch` trigger for `build-security` (mastodon#29041) * Configure selenium to use Chrome version 120 (mastodon#29038) * Fix security builds not being marked latest * Merge pull request from GHSA-3fjr-858r-92rw * Fix insufficient origin validation * Bump version to 4.3.0-alpha.1 * Fix build-security workflow for glitch-soc * Restore -streaming suffix for security builds (glitch-soc#2602) * Temporary hack to correctly tag the security docker image… * Fix build-security docker tags --------- Signed-off-by: Claire <claire.github-309c@sitedethib.com> Co-authored-by: Eugen Rochko <eugen@zeonfederated.com> Co-authored-by: Claire <claire.github-309c@sitedethib.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Matt Jankowski <matt@jankowski.online> Co-authored-by: KMY（雪あすか） <tt@kmycode.net> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: Aaron Brady <aaron@insom.me.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes here:
let!setup not used in specs, moved to before blocksinclude