Clean up of RSpec/LetSetup within spec/models

[mjankowski]

This is another approach to the previously closed #28368 focused just on some of the models specs, and attempting to not just move things to before blocks unless that made sense. Summary:

• The canonical email block is a very short spec and the changed line seems to genuinely be setup code that is running in a let! - move this to a before
• The other two had reasonable assertions to add about the previously unused vars, which reflects why they were being created

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6fed0fc) 84.28% compared to head (99fccca) 84.31%.
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #28444      +/-   ##
==========================================
+ Coverage   84.28%   84.31%   +0.02%     
==========================================
  Files        1039     1039              
  Lines       28226    28226              
  Branches     4550     4550              
==========================================
+ Hits        23790    23798       +8     
+ Misses       3287     3279       -8     
  Partials     1149     1149              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.